Date: Mon, 18 Oct 2004 20:35:16 +0300 From: Ruslan Ermilov <ru@freebsd.org> To: "David E. O'Brien" <obrien@freebsd.org> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S Message-ID: <20041018173516.GB89681@ip.net.ua> In-Reply-To: <200410181719.i9IHJa9l097436@repoman.freebsd.org> References: <200410181719.i9IHJa9l097436@repoman.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Mon, Oct 18, 2004 at 05:19:36PM +0000, David E. O'Brien wrote: > obrien 2004-10-18 17:19:36 UTC > > FreeBSD src repository > > Modified files: > lib/libc/i386/net htonl.S ntohl.S > Log: > Sync with sys/i386/include/endian.h: use the single instruction 'bswap'. > > Revision Changes Path > 1.10 +4 -0 src/lib/libc/i386/net/htonl.S > 1.10 +4 -0 src/lib/libc/i386/net/ntohl.S : ENTRY(__htonl) : movl 4(%esp),%eax : +#ifdef I386_CPU : xchgb %al,%ah : roll $16,%eax : xchgb %al,%ah : +#else : + bswap %eax : +#endif : ret Ahem, but this makes this code unsuitable for i386. I386_CPU is only defined if kernel config file has "cpu I386_CPU", and this has little relation to libc if at all. Cheers, -- Ruslan Ermilov ru@FreeBSD.org FreeBSD committer [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBc/7UqRfpzJluFF4RAlb0AKCKBkmPwZ4YfmT8DjXGnPqFBghLJACeO+Q1 kf9ogMEfcUZVtZIln0505rw= =KpE8 -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041018173516.GB89681>