Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 30 Jul 2019 18:21:46 +0100
From:      Ruslan Bukin <br@bsdpad.com>
To:        Toomas Soome <tsoome@me.com>
Cc:        Ruslan Bukin <br@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r350444 - head/stand/efi/loader
Message-ID:  <20190730172146.GA97694@bsdpad.com>
In-Reply-To: <B6D15575-028D-44AC-8773-3920CC89BCAC@me.com>
References:  <201907301454.x6UEsIVC045133@repo.freebsd.org> <B6D15575-028D-44AC-8773-3920CC89BCAC@me.com>

next in thread | previous in thread | raw e-mail | index | archive | help
Hi

No, this is linking-stage fix only.
efinet.c, efihttp.c are still included to the build

I guess we could exclude them from compilation as it makes no sense

Ruslan

On Tue, Jul 30, 2019 at 07:00:34PM +0300, Toomas Soome wrote:
> hi!
> 
> efihttp is also using network, is it intentionally left untouched?
> 
> rgds,
> toomas
> 
> > On 30 Jul 2019, at 17:54, Ruslan Bukin <br@FreeBSD.org> wrote:
> > 
> > Author: br
> > Date: Tue Jul 30 14:54:18 2019
> > New Revision: 350444
> > URL: https://svnweb.freebsd.org/changeset/base/350444
> > 
> > Log:
> >  Fix EFI loader build when LOADER_NET_SUPPORT=no.
> > 
> >  Sponsored by:	DARPA, AFRL
> > 
> > Modified:
> >  head/stand/efi/loader/conf.c
> > 
> > Modified: head/stand/efi/loader/conf.c
> > ==============================================================================
> > --- head/stand/efi/loader/conf.c	Tue Jul 30 14:21:00 2019	(r350443)
> > +++ head/stand/efi/loader/conf.c	Tue Jul 30 14:54:18 2019	(r350444)
> > @@ -40,7 +40,9 @@ struct devsw *devsw[] = {
> > 	&efipart_cddev,
> > 	&efipart_hddev,
> > 	&efihttp_dev, /* ordering with efinet_dev matters */
> > +#if defined(LOADER_NET_SUPPORT)
> > 	&efinet_dev,
> > +#endif
> > 	&vdisk_dev,
> > #ifdef EFI_ZFS_BOOT
> > 	&zfs_dev,
> > @@ -64,7 +66,9 @@ struct fs_ops *file_system[] = {
> > };
> > 
> > struct netif_driver *netif_drivers[] = {
> > +#if defined(LOADER_NET_SUPPORT)
> > 	&efinetif,
> > +#endif
> > 	NULL
> > };
> > 
> > 
> 
> 




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190730172146.GA97694>