Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 31 Aug 2024 09:47:48 +0000
From:      bugzilla-noreply@freebsd.org
To:        bugs@FreeBSD.org
Subject:   [Bug 281151] [patch] source upgrade path broken for stable/12 to stable/13 due to bmake
Message-ID:  <bug-281151-227@https.bugs.freebsd.org/bugzilla/>

next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D281151

            Bug ID: 281151
           Summary: [patch] source upgrade path broken for stable/12 to
                    stable/13 due to bmake
           Product: Base System
           Version: 13.4-STABLE
          Hardware: Any
                OS: Any
            Status: New
          Keywords: easy, patch-ready
          Severity: Affects Some People
          Priority: ---
         Component: bin
          Assignee: bugs@FreeBSD.org
          Reporter: eugen@freebsd.org
                CC: sjg@FreeBSD.org

I've just tried to "make builworld WITHOUT_TESTS=3D" with stable/12 system =
to
upgrade it to stable/13 and it failed:

=3D=3D=3D> usr.bin/bmake (obj)
=3D=3D=3D> usr.bin/bmake/unit-tests (obj)
make[6]: "/usr/src/usr.bin/bmake/unit-tests/Makefile" line 445: Malformed
conditional (${.SHELL:T}
=3D=3D "ksh")
make[6]: "/usr/src/usr.bin/bmake/unit-tests/Makefile" line 774: Malformed
conditional (${.SHELL:T}
=3D=3D "ksh")
make[6]: Fatal errors encountered -- cannot continue


Please consider something like the following change to respect WITHOUT_TEST=
S:

--- usr.bin/bmake/Makefile.orig       2024-08-31 08:37:49.762012000 +0000
+++ usr.bin/bmake/Makefile    2024-08-31 09:38:30.244280000 +0000
@@ -87,7 +87,8 @@
 .PATH: ${srcdir}

 .if make(obj) || make(clean)
-SUBDIR+=3D unit-tests
+HAS_TESTS=3D
+SUBDIR.${MK_TESTS}+=3D   unit-tests
 .endif

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-281151-227>