Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 10 Jan 2025 21:39:12 +0000
From:      bugzilla-noreply@freebsd.org
To:        bugs@FreeBSD.org
Subject:   [Bug 283679] in release, make ftp fails, because DISTDIR in base conflicts with DISTDIR in ports
Message-ID:  <bug-283679-227-9yIq5tpFyd@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-283679-227@https.bugs.freebsd.org/bugzilla/>
References:  <bug-283679-227@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D283679

--- Comment #5 from Ed Maste <emaste@freebsd.org> ---
> Can you double check whether commit 41adc5f29ba6955e09f46e4d2c25da6fcd263=
ba2

It looks like etcupdate's extract_tree (or similar) is failing in NO_ROOT m=
ode.
In NO_ROOT mode we place METALOG in `mktemp -d
$WORKDIR/etcupdate-XXXXXXXX`/$DISTDIR/METALOG -- with DISTDIR unset this
"works."

Maybe etcupdate should explicitly set DISTDIR when it invokes targets that =
use
METALOG, something like:

diff --git a/usr.sbin/etcupdate/etcupdate.sh b/usr.sbin/etcupdate/etcupdate=
.sh
index 39d1f9e56a54..402b3bd939ec 100755
--- a/usr.sbin/etcupdate/etcupdate.sh
+++ b/usr.sbin/etcupdate/etcupdate.sh
@@ -226,10 +226,10 @@ build_tree()
                                fi
                        fi
                        if [ -n "$($make -V.ALLTARGETS:Minstalletc)" ]; then
-                               $make DESTDIR=3D$destdir installetc || exit=
 1
+                               $make DESTDIR=3D$destdir DISTDIR=3D. instal=
letc ||
exit 1
                        else
-                               $make DESTDIR=3D$destdir distrib-dirs || ex=
it 1
-                               $make DESTDIR=3D$destdir distribution || ex=
it 1
+                               $make DESTDIR=3D$destdir DISTDIR=3D. distri=
b-dirs
|| exit 1
+                               $make DESTDIR=3D$destdir DISTDIR=3D. distri=
bution
|| exit 1
                        fi
                ) || return 1
        fi

(regardless we should disentangle ports and src use of DISTDIR)

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-283679-227-9yIq5tpFyd>