Date: Thu, 11 Sep 2003 10:29:46 -0400 From: Tom Rhodes <trhodes@FreeBSD.org> To: Maxime Henrion <mux@FreeBSD.org> Cc: src-committers@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/sysinstall config.c Message-ID: <20030911102946.5c1639fe.trhodes@FreeBSD.org> In-Reply-To: <20030911145510.GB83361@elvis.mu.org> References: <200309102055.h8AKtA7N027631@repoman.freebsd.org> <20030911062400.GA83361@elvis.mu.org> <20030911000107.B38429@12-234-22-23.pyvrag.nggov.pbz> <20030911093434.18760596.trhodes@FreeBSD.org> <20030911145510.GB83361@elvis.mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 11 Sep 2003 16:55:10 +0200
Maxime Henrion <mux@FreeBSD.org> wrote:
> Tom Rhodes wrote:
> > On Thu, 11 Sep 2003 00:06:16 -0700 (PDT)
> > Doug Barton <DougB@freebsd.org> wrote:
> >
> > > On Thu, 11 Sep 2003, Maxime Henrion wrote:
> > >
> > > > Tom Rhodes wrote:
> > > > > trhodes 2003/09/10 13:55:10 PDT
> > > > >
> > > > > FreeBSD src repository
> > > > >
> > > > > Modified files:
> > > > > usr.sbin/sysinstall config.c
> > > > > Log:
> > > > > With the exim port upgrade, modify sysinstall(8):
> > > > >
> > > > > - Add 'enable_exim="YES"' to rc.conf(5)
> > > > [...]
> > > >
> > > > All other rc.conf(5) options that enable services are of the form
> > > > <service>_enable. Why the difference here?
> > >
> > > Yeah, this is evil and should be changed. There is not guarantee that
> > > this won't totally break someday.
> >
> >
> > Quoting Simon since he already answered this:
> >
> > It is actually not an issue, since it was just a typo in Tom's commit
> > message, not the actual code. The actual code is :
> >
> > --- src/usr.sbin/sysinstall/config.c 2003/08/03 05:55:21 1.212
> > +++ src/usr.sbin/sysinstall/config.c 2003/09/10 20:55:09 1.213
> > [CUT]
> > + variable_set2("exim_enable", "YES", 1);
> >
> >
> > Is there still a problem Doug, Maxime? I can do a forced commit,
> > or when I commit the change being discussed with Ceri I could make
> > a comment about the previous revision.
>
> No problems at all. I should probably have checked in the code before
> sending this e-mail, and I actually did, but I read wrong - probably
> because it was early in the morning :-). It might be a good idea to do
> a forced commit, though I don't think it's really needed for such a
> small typo.
Well, I agree that a forced commit for a small typo like this is
rather worthless. However, I'm committing to this area soon per
my conversation with Ceri.
--
Tom Rhodes
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030911102946.5c1639fe.trhodes>