Date: Fri, 14 Jul 2000 20:28:39 +0900 From: haro@tk.kubota.co.jp (Munehiro Matsuda) To: Archie Cobbs <archie@FreeBSD.org> Cc: freebsd-current@freebsd.org, freebsd-ports@freebsd.org Subject: ether_ifattach() change and VMware Message-ID: <20000714202839P.haro@tk.kubota.co.jp>
next in thread | raw e-mail | index | archive | help
Date: Thu, 13 Jul 2000 15:54:35 -0700 (PDT) From: Archie Cobbs <archie@FreeBSD.org> :: ::archie 2000/07/13 15:54:35 PDT :: :: Modified files: <snip> :: Log: :: Make all Ethernet drivers attach using ether_ifattach() and detach using :: ether_ifdetach(). :: :: The former consolidates the operations of if_attach(), ng_ether_attach(), :: and bpfattach(). The latter consolidates the corresponding detach operations. :: :: Reviewed by: julian, freebsd-net Hello, After the commit, VMware seems to hang the system at boot time. The "vmnet" module, that comes with VMware, needs the included patch. Shouldn't we bump version or something, due to the kernel API change? ---8<------8<------8<-- patch for VMware --8<------8<------8<------8<--- --- vmnet-only/freebsd/vmnet.c.org Fri Jul 14 16:18:50 2000 +++ vmnet-only/freebsd/vmnet.c Fri Jul 14 16:21:51 2000 @@ -156,9 +156,7 @@ DLog(Linfo, DEVICE_NAME "%d: Ethernet address: %6D", ifp->if_unit, sc->iface.arpcom.ac_enaddr, ":"); s = splimp(); - if_attach(ifp); - ether_ifattach(ifp); - bpfattach(ifp, DLT_EN10MB, sizeof(struct ether_header)); + ether_ifattach(ifp, ETHER_BPF_SUPPORTED); splx(s); return 0; ---8<------8<------8<------8<------8<------8<------8<------8<------8<--- Thank you, Haro =------------------------------------------------------------------------------ _ _ Munehiro (haro) Matsuda -|- /_\ |_|_| Business Incubation Dept., Kubota Corp. /|\ |_| |_|_| 1-3 Nihonbashi-Muromachi 3-Chome Chuo-ku Tokyo 103-8310, Japan Tel: +81-3-3245-3318 Fax: +81-3-3245-3315 Email: haro@kubota.co.jp To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000714202839P.haro>