Date: Wed, 01 Apr 2026 07:29:58 +0000 From: Enji Cooper <ngie@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Weixie Cui <cuiweixie@gmail.com> Subject: git: f3b59bf28504 - main - bce: Fix SYSCTL_IN error check in bce_sysctl_nvram_write() Message-ID: <69ccc976.24e0d.305fe761@gitrepo.freebsd.org>
index | next in thread | raw e-mail
The branch main has been updated by ngie: URL: https://cgit.FreeBSD.org/src/commit/?id=f3b59bf28504f901f4fcb568004a92c02fa371ed commit f3b59bf28504f901f4fcb568004a92c02fa371ed Author: Weixie Cui <cuiweixie@gmail.com> AuthorDate: 2026-03-31 13:51:46 +0000 Commit: Enji Cooper <ngie@FreeBSD.org> CommitDate: 2026-04-01 07:29:46 +0000 bce: Fix SYSCTL_IN error check in bce_sysctl_nvram_write() The condition after SYSCTL_IN was inverted: success (error == 0) returned immediately and skipped the NVRAM write path, while failure fell through. Return only when SYSCTL_IN fails. Signed-off-by: Weixie Cui <cuiweixie@gmail.com> Reviewed-by: ngie Pull-Request: https://github.com/freebsd/freebsd-src/pull/2113 --- sys/dev/bce/if_bce.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/bce/if_bce.c b/sys/dev/bce/if_bce.c index 6cf39e035ea6..84992af0c6b8 100644 --- a/sys/dev/bce/if_bce.c +++ b/sys/dev/bce/if_bce.c @@ -8861,7 +8861,7 @@ bce_sysctl_nvram_write(SYSCTL_HANDLER_ARGS) bzero(sc->nvram_buf, sc->bce_flash_size); error = SYSCTL_IN(req, sc->nvram_buf, sc->bce_flash_size); - if (error == 0) + if (error != 0) return (error); if (req->newlen == sc->bce_flash_size)home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?69ccc976.24e0d.305fe761>