Date: Tue, 28 Jul 2015 17:43:25 +0300 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Renato Botelho <garga@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r285945 - head/sys/netpfil/pf Message-ID: <20150728144325.GZ72729@FreeBSD.org> In-Reply-To: <DA51CE87-C20B-46FB-8684-106CDF9B558F@FreeBSD.org> References: <201507281031.t6SAVZnu046387@repo.freebsd.org> <20150728112051.GT72729@FreeBSD.org> <DA51CE87-C20B-46FB-8684-106CDF9B558F@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Renato,
On Tue, Jul 28, 2015 at 10:18:57AM -0300, Renato Botelho wrote:
R> Thanks for pointing this out. Do you approve the following patch?
R>
R> Index: sys/netpfil/pf/pf.c
R> ===================================================================
R> --- sys/netpfil/pf/pf.c (revision 285945)
R> +++ sys/netpfil/pf/pf.c (working copy)
R> @@ -5895,8 +5895,7 @@
R> !((s && s->state_flags & PFSTATE_ALLOWOPTS) || r->allow_opts)) {
R> action = PF_DROP;
R> REASON_SET(&reason, PFRES_IPOPTIONS);
R> - if (r->log)
R> - log = 1;
R> + log = r->log;
R> DPFPRINTF(PF_DEBUG_MISC,
R> ("pf: dropping packet with ip options\n"));
R> }
R> @@ -6330,8 +6329,7 @@
R> !((s && s->state_flags & PFSTATE_ALLOWOPTS) || r->allow_opts)) {
R> action = PF_DROP;
R> REASON_SET(&reason, PFRES_IPOPTIONS);
R> - if (r->log)
R> - log = 1;
R> + log = r->log;
R> DPFPRINTF(PF_DEBUG_MISC,
R> ("pf: dropping packet with dangerous v6 headers\n"));
R> }
Yes, this looks better. Thanks.
--
Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150728144325.GZ72729>