Date: Sun, 15 Apr 2012 13:01:26 +0100 From: Chris Rees <crees@FreeBSD.org> To: Pawel Pekala <pawel@freebsd.org> Cc: Michael Scheidell <scheidell@freebsd.org>, cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/deskutils/cairo-dock-plugins Makefile distinfo ports/deskutils/cairo-dock-plugins/files patch-CDBashApplet.sh patch-Doncky-data-nvidia-config patch-GMenu-applet-menu patch-Network-Monitor-data-access-point patch-Network-Monitor- Message-ID: <CADLo838SjqUE=Hbi%2BuUZnKfcUtYnG4jJOYHPdmra7_fks3r9_g@mail.gmail.com>
index | next in thread | raw e-mail
On 15 April 2012 12:29, Pawel Pekala <pawel@freebsd.org> wrote:
> Hello Michael,
>
> Dnia 2012-04-14, o godz. 21:51:16
> Michael Scheidell <scheidell@FreeBSD.org> napisał(a):
>
>> deskutils/cairo-dock-plugins/files patch-CDBashApplet.sh
>> patch-Doncky-data-nvidia-config
>> patch-GMenu-applet-menu
>> patch-Network-Monitor-data-access-point
>> patch-Network-Monitor-data-wifi
>> patch-System-Monitor-data-nvidia-config
>> patch-System-Monitor.conf.in
>> patch-applet-appli-finder.c
>> patch-applet-notifications.c
>> patch-calc.sh
>> patch-demo_bash.sh
>> patch-netspeed
>> patch-updatedb.sh
>> patch-upload2free.sh
>> patch-wifi-data-access-point
>> patch-wifi-data-wifi
>
> This will break when LOCALBASE != /usr/local and it's user-settable
> variable as documented in ports(7). And two small questions:
> - could some of this be better solved by using REINPLACE_CMD ?
> - there's a lot bash scripts, shouldn't be there RUN_DEPENDS+= bash ?
For LOCALBASE_safeness we should use #!/usr/bin/env bash à la perl.
${REINPLACE_CMD} -e '1s,^#!/bin/bash,#!/usr/bin/env bash,'
If you can get upstream to do this as well, that'd mean it won't break
on other OSes too!
Chris
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo838SjqUE=Hbi%2BuUZnKfcUtYnG4jJOYHPdmra7_fks3r9_g>