Date: Fri, 09 Jul 2010 11:07:30 -0700 From: Doug Barton <dougb@FreeBSD.org> To: John Baldwin <jhb@freebsd.org> Cc: ports@freebsd.org Subject: Re: Review request for new port: sysutils/etcupdate Message-ID: <4C376562.5000809@FreeBSD.org> In-Reply-To: <201007090827.09471.jhb@freebsd.org> References: <201007081750.00871.jhb@freebsd.org> <alpine.BSF.2.00.1007081505550.48494@yncgbc.qbhto.arg> <201007090827.09471.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 07/09/10 05:27, John Baldwin wrote: > On Thursday, July 08, 2010 6:12:39 pm Doug Barton wrote: >> On Thu, 8 Jul 2010, John Baldwin wrote: >> >>> This is a port for yet-another-/etc-merging tool that I wrote recently. > It >>> passes portlint -N with one bogus warning because /etc is in the comment. >> >> I didn't try installing/deinstalling but you seem to have the right >> stuff in the Makefile for that. Overall it looks good, just a couple >> comments: >> 1. I don't think textproc is right for CATEGORIES, although sysutils is >> of course. >> 2. I don't think the do-fetch target is necessary, but if it is needed >> when you test it that's fine. >> 3. You have a pkg-descr~ file in the shar that should be deleted before >> you commit it. >> >> Assuming it passes all the tests in the porter's handbook for install, >> deinstall, package, etc. I'd say go ahead. :) > > Ok. Should I fix 1) and 2) for the sysutils/etcmerge port as well? (I used > etcmerge as a template.) I think removing textproc is a no-brainer, unless someone has a different opinion. :) I don't have a do-fetch target in portmaster's port (which also has the src in the tree), and given the fact that DISTFILES is explicitly set empty I don't see why one would be necessary at all. So, short answer, yes, if you don't mind. Otherwise I'll be glad to do it, just let me know. Doug -- ... and that's just a little bit of history repeating. -- Propellerheads Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4C376562.5000809>