Date: Sun, 17 Aug 2008 16:09:07 +0100 From: Dieter <freebsd@sopwith.solgatos.com> To: Sean Bruno <sbruno@miralink.com> Cc: Scott Long <scottl@samsco.org>, freebsd-firewire@freebsd.org Subject: Re: fwcontrol update Message-ID: <200808172309.XAA21188@sopwith.solgatos.com> In-Reply-To: Your message of "Sun, 17 Aug 2008 10:34:50 PDT." <48A8613A.4000506@miralink.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> >> len = read(fd, buf, 1024*16); > > > > It would be good practice to check for read failing. > > Indeed it would. I looked into fwdev.c::fw_read() a little bit and > documented what I think it's doing as well. > BTW, did the compile warnings on AMD64 go away? I still need to give it a closer inspection, and run some tests, but it looks good so far. And gcc isn't complaining (7.0 on AMD64).
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200808172309.XAA21188>