Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 03 Feb 2009 21:39:31 +0100
From:      Christoph Mallon <christoph.mallon@gmx.de>
To:        Warner Losh <imp@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r188098 - head/lib/libc/string
Message-ID:  <4988AB83.2050203@gmx.de>
In-Reply-To: <200902032025.n13KPaCV041012@svn.freebsd.org>
References:  <200902032025.n13KPaCV041012@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Warner Losh schrieb:
> Author: imp
> Date: Tue Feb  3 20:25:36 2009
> New Revision: 188098
> URL: http://svn.freebsd.org/changeset/base/188098
> 
> Log:
>   Fix the functions to match prototypes.  The K&R definitions differ
>   from the ANSI-C prototype due to the 'int promotion' rule.
> 
> Modified:
>   head/lib/libc/string/memchr.c
>   head/lib/libc/string/strmode.c
>   head/lib/libc/string/wmemset.c
[...]
> Modified: head/lib/libc/string/strmode.c
> ==============================================================================
> --- head/lib/libc/string/strmode.c	Tue Feb  3 20:01:51 2009	(r188097)
> +++ head/lib/libc/string/strmode.c	Tue Feb  3 20:25:36 2009	(r188098)
> @@ -38,7 +38,7 @@ __FBSDID("$FreeBSD$");
>  #include <string.h>
>  
>  void
> -strmode(mode_t mode, char *p)
> +strmode(/* mode_t */ int mode, char *p)
>  {
>  	 /* print type */
>  	switch (mode & S_IFMT) {

The manpage states that the first parameter of strmode() is a mode_t. 
What's wrong - the implementation (both in header and definition) or the 
documentation?



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4988AB83.2050203>