Skip site navigation (1)Skip section navigation (2) 
Date:      Sun, 9 Jul 2023 15:02:09 +0100
From:      Nuno Teixeira <eduardo@freebsd.org>
To:        Po-Chuan Hsieh <sunpoet@freebsd.org>
Cc:        Juraj Lutter <otis@freebsd.org>, ports-committers@freebsd.org,  dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject:   Re: git: 4e184db51f52 - main - textproc/kibana8: Update to 8.8.2
Message-ID:  <CAFDf7UJMHzeeRxRF=9GgOvnsCapk2H1fbbjjkt35vHuLdHCA=g@mail.gmail.com>
In-Reply-To: <CAMHz58TnLEWg36yJWgfbNOKoqqXEY3ktMpJ1tO0qwwhVrLFtTQ@mail.gmail.com>
References:  <202307091255.369CtMsX004111@gitrepo.freebsd.org> <CAMHz58TnLEWg36yJWgfbNOKoqqXEY3ktMpJ1tO0qwwhVrLFtTQ@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail 

[-- Attachment #1 --]
Hello,

That's a good example to try to understand why some ports use
${LOCALBASE}/bin/file:<cat>/<port>
instead of:
<port>:<cat>/<port>
since we have much better control on correct version to use like above:
npm-node16*>=9.7.2*:www/npm-node16

Po-Chuan Hsieh <sunpoet@freebsd.org> escreveu no dia domingo, 9/07/2023
à(s) 14:38:

> On Sun, Jul 9, 2023 at 8:55 PM Juraj Lutter <otis@freebsd.org> wrote:
>
>> The branch main has been updated by otis:
>>
>> URL:
>> https://cgit.FreeBSD.org/ports/commit/?id=4e184db51f5213b96a3fa2e853111b3d76e75928
>>
>> commit 4e184db51f5213b96a3fa2e853111b3d76e75928
>> Author:     Juraj Lutter <otis@FreeBSD.org>
>> AuthorDate: 2023-07-03 14:18:10 +0000
>> Commit:     Juraj Lutter <otis@FreeBSD.org>
>> CommitDate: 2023-07-09 12:55:00 +0000
>>
>>     textproc/kibana8: Update to 8.8.2
>>
>>     - Update to 8.8.2
>>     - Regen patches
>>
>>     Release notes:
>>     https://www.elastic.co/guide/en/kibana/8.8/release-notes-8.8.2.html
>> ---
>> @@ -80,14 +84,15 @@ do-configure:
>>                 "! ( -name \.* -or -path *\/test\/* -or -name test )")
>>         (cd ${_RE2DIR} && \
>>                 ${SETENV} HOME=${WRKDIR} \
>> -
>>  ${LOCALBASE}/lib/node_modules/npm/bin/node-gyp-bin/node-gyp configure \
>> +
>>  ${LOCALBASE}/lib/node_modules/npm/node_modules/.bin/node-gyp configure \
>>
>
> Would you like to update BUILD_DEPENDS to ensure that the correct npm
> version (9.7.2+) is used?
> It also applies to textproc/kibana7.
> Thanks.
>
> -BUILD_DEPENDS=     ${LOCALBASE}/bin/npm:www/npm-node16
> +BUILD_DEPENDS=       npm-node16>=9.7.2:www/npm-node16
>


-- 
Nuno Teixeira
FreeBSD Committer (ports)

[-- Attachment #2 --]
<div dir="ltr"><div>Hello,</div><div><br></div><div>That&#39;s a good example to try to understand why some ports use </div><div>${LOCALBASE}/bin/file:&lt;cat&gt;/&lt;port&gt;</div><div>instead of:</div><div>&lt;port&gt;:&lt;cat&gt;/&lt;port&gt;</div><div>since we have much better control on correct version to use like above:<br></div><div>npm-node16<b>&gt;=9.7.2</b>:www/npm-node16</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Po-Chuan Hsieh &lt;<a href="mailto:sunpoet@freebsd.org">sunpoet@freebsd.org</a>&gt; escreveu no dia domingo, 9/07/2023 à(s) 14:38:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr">On Sun, Jul 9, 2023 at 8:55 PM Juraj Lutter &lt;<a href="mailto:otis@freebsd.org" target="_blank">otis@freebsd.org</a>&gt; wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The branch main has been updated by otis:<br>
<br>
URL: <a href="https://cgit.FreeBSD.org/ports/commit/?id=4e184db51f5213b96a3fa2e853111b3d76e75928" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/ports/commit/?id=4e184db51f5213b96a3fa2e853111b3d76e75928</a><br>;
<br>
commit 4e184db51f5213b96a3fa2e853111b3d76e75928<br>
Author:     Juraj Lutter &lt;otis@FreeBSD.org&gt;<br>
AuthorDate: 2023-07-03 14:18:10 +0000<br>
Commit:     Juraj Lutter &lt;otis@FreeBSD.org&gt;<br>
CommitDate: 2023-07-09 12:55:00 +0000<br>
<br>
    textproc/kibana8: Update to 8.8.2<br>
<br>
    - Update to 8.8.2<br>
    - Regen patches<br>
<br>
    Release notes:<br>
    <a href="https://www.elastic.co/guide/en/kibana/8.8/release-notes-8.8.2.html" rel="noreferrer" target="_blank">https://www.elastic.co/guide/en/kibana/8.8/release-notes-8.8.2.html</a><br>;
---<br>
@@ -80,14 +84,15 @@ do-configure:<br>
                &quot;! ( -name \.* -or -path *\/test\/* -or -name test )&quot;)<br>
        (cd ${_RE2DIR} &amp;&amp; \<br>
                ${SETENV} HOME=${WRKDIR} \<br>
-               ${LOCALBASE}/lib/node_modules/npm/bin/node-gyp-bin/node-gyp configure \<br>
+               ${LOCALBASE}/lib/node_modules/npm/node_modules/.bin/node-gyp configure \<br></blockquote><div><br></div><div>Would you like to update BUILD_DEPENDS to ensure that the correct npm version (9.7.2+) is used?</div><div>It also applies to textproc/kibana7.</div><div>Thanks.</div><div><br></div>-BUILD_DEPENDS=     ${LOCALBASE}/bin/npm:www/npm-node16<br><div>+BUILD_DEPENDS=       npm-node16&gt;=9.7.2:www/npm-node16</div></div></div>
</blockquote></div><br clear="all"><br><span class="gmail_signature_prefix">-- </span><br><div dir="ltr" class="gmail_signature"><div dir="ltr"><span style="color:rgb(102,102,102)">Nuno Teixeira<br>FreeBSD Committer (ports)</span></div></div>
home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7UJMHzeeRxRF=9GgOvnsCapk2H1fbbjjkt35vHuLdHCA=g>