Date: Tue, 23 Aug 2016 01:15:21 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 209742] devel/godot: Update to 2.1; add devel/godot-tools port Message-ID: <bug-209742-13-GmBBWvoYqJ@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-209742-13@https.bugs.freebsd.org/bugzilla/> References: <bug-209742-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D209742 lightside <lightside@gmx.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173942|maintainer-approval?(FreeBS | Flags|D@ShaneWare.Biz) | Attachment #173942|0 |1 is obsolete| | Attachment #173959| |maintainer-approval?(FreeBS Flags| |D@ShaneWare.Biz) --- Comment #79 from lightside <lightside@gmx.com> --- Created attachment 173959 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D173959&action= =3Dedit Proposed patch (since 415742 revision) (In reply to comment #76) > OPTIONS_DEFAULT=3D OSS I noticed, that you proposed to remove "+=3D". This is ok, if there are no = other default option(s) used for devel/godot-tools port (The EXAMPLES option is n= ot affected). The removal of OPTIONS_DEFINE+=3DDEBUG (and related code) is not ok, because there is a target=3Ddebug option available, which maybe used for tools=3Dno= and tools=3Dyes options: https://github.com/godotengine/godot/blob/2.1-stable/SConstruct#L116 https://github.com/godotengine/godot/blob/2.1-stable/SConstruct#L181 https://github.com/godotengine/godot/blob/2.1-stable/SConstruct#L269 The "+=3D" used, because OPTIONS_DEFINE=3DEXAMPLES defined in devel/godot-t= ools port. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-209742-13-GmBBWvoYqJ>