Date: Tue, 12 Dec 2017 12:39:38 -0800 (PST) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> To: Warner Losh <imp@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r326809 - head/sys/dev/cardbus Message-ID: <201712122039.vBCKdcV8088346@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <201712122022.vBCKM9Kd050769@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> Author: imp > Date: Tue Dec 12 20:22:09 2017 > New Revision: 326809 > URL: https://svnweb.freebsd.org/changeset/base/326809 > > Log: > 1k objects on the stack are a bad idea. While it's likely safe in this > context, it's also safe to allocate the memory and free it instead. > > Noticed by: Eugene Grosbein's script YEA!!! One down, 20 to go and then see how the kstack issue does? And thank you for quickly fixing this. > Modified: > head/sys/dev/cardbus/cardbus_cis.c > > Modified: head/sys/dev/cardbus/cardbus_cis.c > ============================================================================== > --- head/sys/dev/cardbus/cardbus_cis.c Tue Dec 12 20:15:57 2017 (r326808) > +++ head/sys/dev/cardbus/cardbus_cis.c Tue Dec 12 20:22:09 2017 (r326809) > @@ -583,7 +583,7 @@ int > cardbus_parse_cis(device_t cbdev, device_t child, ... -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201712122039.vBCKdcV8088346>