Date: Mon, 20 Jan 2014 17:18:44 -0500 From: Alexander Kabaev <kabaev@gmail.com> To: John Baldwin <jhb@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Rui Paulo <rpaulo@felyko.com>, Neel Natu <neel@freebsd.org> Subject: Re: svn commit: r260898 - head/sys/kern Message-ID: <20140120171844.69e065fb@kan.dyndns.org> In-Reply-To: <1536225.gsjt6oXMt2@pippin.baldwin.cx> References: <201401200159.s0K1xa5X012123@svn.freebsd.org> <EA6A69A5-0620-4BF9-9871-268C416D2F58@felyko.com> <1536225.gsjt6oXMt2@pippin.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
--Sig_/4Nq8uq1Kwyltm5a_lSUxb8g Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Mon, 20 Jan 2014 11:32:29 -0500 John Baldwin <jhb@freebsd.org> wrote: > On Sunday 19 January 2014 18:18:03 Rui Paulo wrote: > > On 19 Jan 2014, at 17:59, Neel Natu <neel@FreeBSD.org> wrote: > > > Author: neel > > > Date: Mon Jan 20 01:59:35 2014 > > > New Revision: 260898 > > > URL: http://svnweb.freebsd.org/changeset/base/260898 > > >=20 > > > Log: > > > Bump up WITNESS_COUNT from 1024 to 1536 so there are sufficient > > > entries for > > > WITNESS to actually work. > >=20 > > This value should be automatically tuned... >=20 > How do you propose to do so? This is the count of locks initialized > before witness' own SYSINIT is executed and the array it sizes is > allocated statically at compile time. This used to not be a static > array, but an intrusive list embedded in locks themselves, but we > decided to shave a pointer off of each lock that was only used for > that and to use a statically sized table instead. >=20 > --=20 > John Baldwin As <CONSTANT1> + <CONSTANT2> * MAXCPU, as evidently most recent overflows reported were caused by jacking MAXCPU up from its default value?=20 --=20 Alexander Kabaev --Sig_/4Nq8uq1Kwyltm5a_lSUxb8g Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iD8DBQFS3aDKQ6z1jMm+XZYRAp+IAKDIHTjvWXE/8tNIgf40M0GEy3dq7gCg03vv p13tn1pl50ZOMn2FcSunO/E= =7LMU -----END PGP SIGNATURE----- --Sig_/4Nq8uq1Kwyltm5a_lSUxb8g--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140120171844.69e065fb>