Date: Tue, 03 Sep 2019 14:06:46 -0000 From: Conrad Meyer <cem@freebsd.org> To: Ed Maste <emaste@freebsd.org> Cc: Xin LI <delphij@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r345900 - head/sbin/fsck_msdosfs Message-ID: <CAG6CVpXyLGNmhH-QMjOsLmrvsD5LO1cnk%2BhVqrG5pYa5F=U2Rg@mail.gmail.com> In-Reply-To: <CAPyFy2C3KXTB7EKnp1PJigjUXY3xB_%2BPUddi43hjp5oKpZP56w@mail.gmail.com> References: <201904050221.x352LGjU015040@repo.freebsd.org> <201904050449.x354nUEC036896@gndrsh.dnsmgr.net> <CAPyFy2C3KXTB7EKnp1PJigjUXY3xB_%2BPUddi43hjp5oKpZP56w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Apr 5, 2019 at 6:49 AM Ed Maste <emaste@freebsd.org> wrote:
>
> On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes <freebsd@gndrsh.dnsmgr.net> wrote:
> >
>
> > > +static const u_char dot_name[] = {
> > > + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' };
> > > +static const u_char dotdot_name[] = {
> > > + '.', '.',' ',' ',' ',' ',' ',' ',' ',' ',' ' };
> > > +
>
> They are all either '.' or ' ', the commas are just list separators.
> IMO spaces after the commas would make it slightly easier to see.
Would it make sense to just use the normal string syntax for char
array assignment?
static const u_char dot_name[11] = ". ";
static const u_char dotdot_name[11] = ".. ";
Seems more clear to me.
Best,
Conrad
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpXyLGNmhH-QMjOsLmrvsD5LO1cnk%2BhVqrG5pYa5F=U2Rg>