Date: Thu, 26 Aug 2010 14:09:55 -0700 From: Xin LI <delphij@delphij.net> To: freebsd-current@freebsd.org Subject: Re: [RFC] ifconfig description support in rc.d Message-ID: <4C76D823.7070703@delphij.net> In-Reply-To: <4C76CA06.5010001@FreeBSD.org> References: <AANLkTinfOSQGnk0%2BPK6iM0=v5CZn2vcmJZbA8TvgGbfr@mail.gmail.com> <4C76CA06.5010001@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.
--------------020709080901060207010303
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On 2010/08/26 13:09, Doug Barton wrote:
> On 08/26/2010 12:53 PM, pluknet wrote:
>> [cc'ing current@ as rc@ looks too quite]
>>
>> Hi.
>>
>> Since ifconfig has grown to label interfaces with
>> ifconfig $ifname description "foobar", what about
>> to give it more life and store i/face descriptions
>> semi-permanently, so they will survive between reboots?
>>
>> This patch adds a functionality to rc.d to label
>> interfaces at boot time.
>>
>> Comments are welcome.
>
> This seems like a good addition, thanks. Please also write a patch for
> rc.conf.5 to describe this new functionality and I'll be happy to commit
> it. One note below.
I have drafted one.
(Note that fxp is a 100Mbps card so it might be sensible to replace it
with just Switch 2?)
>> --- etc/network.subr (revision 211280)
>> +++ etc/network.subr (working copy)
>> @@ -1187,6 +1187,24 @@
>> return 0
>> }
>>
>> +# ifnet_descr
>> +# Add description to all requested interfaces.
>> +#
>> +ifnet_descr()
>> +{
>> + local _if _ifdescr
>> +
>> + # ifconfig_IF_descr
>> + for _if in `ifconfig -l`; do
>> + _ifdescr="`get_if_var $_if ifconfig_IF_descr`"
>> + if [ ! -z "$_ifdescr" ]; then
>
> This is probably better as [ -n "$_ifdescr" ]
>
> Doug
>
- --
Xin LI <delphij@delphij.net> http://www.delphij.net/
FreeBSD - The Power to Serve! Live free or die
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (FreeBSD)
iQEcBAEBCAAGBQJMdtgjAAoJEATO+BI/yjfBywEIALQZMUFUKlkQ/DZjrqBgymFx
Mnj6YkLaPXcvNI5OI15Q3hy730pIZzzNPGKV9ecXLSQ1PikZUIXy5fuRfYh9iXE3
d9f4UgDId0Sn55WmD6/Sfza0oSlH3C1fus6e9NSmm/aR3ekWyLWZzW0wGTgEXFxK
bo0ZcQw7AxRxDLc7EifWUfxV/Ej5pga5YjVyhBBdCoAHl2bPJuFFuxd140Y6+Mlf
gH4zgf2rdGpCWNpWF6L8PsGoVNBoK0R1fUwJZT+GB2ANvMuuQ+jsks+R8h8XFIO6
TE4O8onVcOaoTGZ3873M3CqcO1jfaK5rBfGg3Cr9wUjOkvkQ8SL+k4uvBm4CuX4=
=VtCo
-----END PGP SIGNATURE-----
--------------020709080901060207010303
Content-Type: text/plain;
name="rc.conf.5-ifdescr.diff"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
filename="rc.conf.5-ifdescr.diff"
SW5kZXg6IHJjLmNvbmYuNQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSByYy5jb25mLjUJKHJldmlzaW9u
IDIxMTg0NykKKysrIHJjLmNvbmYuNQkod29ya2luZyBjb3B5KQpAQCAtMTEyOCw2ICsxMTI4
LDE5IEBACiB2YXJpYWJsZXMuCiAuUHAKIElmIGEKKy5WYSBpZmNvbmZpZ18gTnMgQW8gQXIg
aW50ZXJmYWNlIEFjIE5zIFZhIF9kZXNjcgordmFyaWFibGUgaXMgc2V0LCB0aGUgaW50ZXJm
YWNlIHdvdWxkIGJlIGFzc2lnbmVkIHRoZSBkZXNjcmlwdGlvbgorc3BlY2lmaWVkIGJ5IHRo
ZSB2YXJpYWJsZS4KKy5QcAorVG8gYXNzaWduIGFuIGRlc2NyaXB0aW9uIG9mCisuRHEgVXBs
aW5rIHRvIEdpZ2FiaXQgU3dpdGNoIDEKK29uIHRoZSBpbnRlcmZhY2UgbmFtZWQKKy5MaSBl
bTAgOgorLkJkIC1saXRlcmFsCitpZmNvbmZpZ19lbTBfZGVzY3I9IlVwbGluayB0byBHaWdh
Yml0IFN3aXRjaCAxIgorLkVkCisuUHAKK0lmIGEKIC5WYSB2bGFuc18gTnMgQXEgQXIgaW50
ZXJmYWNlCiB2YXJpYWJsZSBpcyBzZXQsCiBhCg==
--------------020709080901060207010303--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4C76D823.7070703>