Date: Thu, 25 Mar 2010 00:26:38 +0100 From: Koop Mast <kwm@FreeBSD.org> To: gahr@FreeBSD.org Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/www/webkit-gtk2 Makefile ports/www/webkit-gtk2/files patch-JavaScriptCore-runtime_JSValue.h Message-ID: <1269473198.17060.388.camel@headache.rainbow-runner.nl> In-Reply-To: <20100324155905.GB29421@gahrfit.gahr.ch> References: <201003241551.o2OFpj9i044724@repoman.freebsd.org> <1269446394.17060.1.camel@headache.rainbow-runner.nl> <20100324155905.GB29421@gahrfit.gahr.ch>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 2010-03-24 at 16:59 +0100, Pietro Cerutti wrote: > On 2010-Mar-24, 16:59, Koop Mast wrote: > > On Wed, 2010-03-24 at 15:51 +0000, Pietro Cerutti wrote: > > > gahr 2010-03-24 15:51:45 UTC > > > > > > FreeBSD ports repository > > > > > > Modified files: > > > www/webkit-gtk2 Makefile > > > Added files: > > > www/webkit-gtk2/files patch-JavaScriptCore-runtime_JSValue.h > > > Log: > > > - Fix build on sparc64 > > > > Who approved this? Btw ia64 fails with the same error. > > Since when one needs an approval for UNBREAK commits? I have no access > to ia64 machines. Sorry, didn't mean it to have this harsh.. Note to self, when sending mail. at least review it. And really don't send any if you are in a hurry. Ok lets try this again. I was under the assumption that if a port got a maintainer, changes should go though them. Even unbreaking stuff like this. Except for things like timeouts and implicit approval. And that I would tell you I was also looking at a fix for webkit on sparc. The ia64 should come out more like: did you know ia64 fails with the same error? I think we can do the same fix and see what pointyhat says about it. Or try to find someone that can help test the patch for us. Couldn't find a build failure for qt4-webkit on ia64 but its probably the same as webkit-gtk2. -Koop http://pointyhat.freebsd.org/errorlogs/ia64-errorlogs/e.8.20100305224420/webkit-gtk2-1.1.15.4_2.log http://pointyhat.freebsd.org/errorlogs/sparc64-errorlogs/e.8.20100315183808/webkit-gtk2-1.1.15.4_2.log > > > > -Koop > > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1269473198.17060.388.camel>