Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 28 Jul 2015 14:59:29 +0000 (UTC)
From:      Renato Botelho <garga@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r285960 - head/sys/netpfil/pf
Message-ID:  <201507281459.t6SExTDW062491@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: garga (ports committer)
Date: Tue Jul 28 14:59:29 2015
New Revision: 285960
URL: https://svnweb.freebsd.org/changeset/base/285960

Log:
  Simplify logic added in r285945 as suggested by glebius
  
  Approved by:	glebius
  MFC after:	3 days
  Sponsored by:	Netgate

Modified:
  head/sys/netpfil/pf/pf.c

Modified: head/sys/netpfil/pf/pf.c
==============================================================================
--- head/sys/netpfil/pf/pf.c	Tue Jul 28 14:20:33 2015	(r285959)
+++ head/sys/netpfil/pf/pf.c	Tue Jul 28 14:59:29 2015	(r285960)
@@ -5895,8 +5895,7 @@ done:
 	    !((s && s->state_flags & PFSTATE_ALLOWOPTS) || r->allow_opts)) {
 		action = PF_DROP;
 		REASON_SET(&reason, PFRES_IPOPTIONS);
-		if (r->log)
-			log = 1;
+		log = r->log;
 		DPFPRINTF(PF_DEBUG_MISC,
 		    ("pf: dropping packet with ip options\n"));
 	}
@@ -6330,8 +6329,7 @@ done:
 	    !((s && s->state_flags & PFSTATE_ALLOWOPTS) || r->allow_opts)) {
 		action = PF_DROP;
 		REASON_SET(&reason, PFRES_IPOPTIONS);
-		if (r->log)
-			log = 1;
+		log = r->log;
 		DPFPRINTF(PF_DEBUG_MISC,
 		    ("pf: dropping packet with dangerous v6 headers\n"));
 	}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201507281459.t6SExTDW062491>