Date: Fri, 11 Jan 2008 12:12:39 -0500 From: John Baldwin <jhb@freebsd.org> To: Konstantin Belousov <kib@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/fdc fdc.c Message-ID: <200801111212.40473.jhb@freebsd.org> In-Reply-To: <200801111650.m0BGorhh009597@repoman.freebsd.org> References: <200801111650.m0BGorhh009597@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday 11 January 2008 11:50:53 am Konstantin Belousov wrote: > kib 2008-01-11 16:50:53 UTC > > FreeBSD src repository > > Modified files: > sys/dev/fdc fdc.c > Log: > The wakeup() line from the rev. 1.319 is wrong and reintroduces > a panic race on module unload. The wakeup() is internal to > kproc_exit/kthread_exit. The correct fix is to fix the msleep() in > detach to sleep on fdc->fdc_thread instead of &fdc->fdc_thread. > > Noted and reviewed by: jhb > Pointy hat to: kib > MFC after: 1 week Original pointy hat to: jhb As I missed updating the msleep() when I fixed the unload race the first time around which lead to the hang seen in the original PR. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200801111212.40473.jhb>