Date: Wed, 10 Mar 2021 16:01:14 +0100 From: Emmanuel Vadot <manu@bidouilliste.com> To: =?ISO-8859-1?Q?S=F8ren?= Schmidt <soren.schmidt@gmail.com> Cc: freebsd-arm <freebsd-arm@freebsd.org> Subject: Re: PinebookPro misc drivers.. Message-ID: <20210310160114.dd9853a0689d257388a745b5@bidouilliste.com> In-Reply-To: <BEA0D66A-7F35-4488-BFDD-E6947A530F18@gmail.com>
index | next in thread | previous in thread | raw e-mail
On Wed, 10 Mar 2021 15:29:21 +0100 Søren Schmidt <soren.schmidt@gmail.com> wrote: > Hi > > I?ve uploaded the latest from my PinebookPro collection here: > https://people.freebsd.org/~sos/PinebookPro/ <https://people.freebsd.org/~sos/PinebookPro/>; > > Comment,, bugs, etc welcome? Few comments, - Could you at least share patches generated with git diff ? - rk_gpiokeys.c doesn't seems correct, we already have sys/dev/gpio/gpiokeys.c so patch this one if it isn't enough for lid switch need. I could comment more if I would be able to diff more easily. > PS: and no I left my commit bit for safe keeping with core many years ago?. You could still open reviews on phab :) > -- > Søren Schmidt > sos@deepcore.dk / sos@freebsd.org > "So much code to hack, so little time" > > > > _______________________________________________ > freebsd-arm@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-arm > To unsubscribe, send any mail to "freebsd-arm-unsubscribe@freebsd.org" -- Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210310160114.dd9853a0689d257388a745b5>