Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 21 Apr 2026 10:43:38 -0500
From:      Kyle Evans <kevans@FreeBSD.org>
To:        Warner Losh <imp@bsdimp.com>, Ed Maste <emaste@freebsd.org>
Cc:        Warner Losh <imp@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject:   Re: git: 4ed20e0236dd - main - kshim/usb: Add build option.
Message-ID:  <10843b7c-32af-404e-820c-100f8b863abb@FreeBSD.org>
In-Reply-To: <a3c0011e-fafa-43e9-8427-915fda50f088@FreeBSD.org>
References:  <69e2efb1.21b3b.32f0016@gitrepo.freebsd.org> <CAPyFy2BOCrtwQozLo0iRXbVf9wXMPEW07QHjmQFbxn6mpNe8aA@mail.gmail.com> <CANCZdfqNE1ZTMXjyFmfFVaZPDEXS0MFZOnJeUk5USwBvUGZP6Q@mail.gmail.com> <CANCZdfook=r878_O8TFYpACQ80nEn943tGr%2Brkc6a_qAadoBJw@mail.gmail.com> <a3c0011e-fafa-43e9-8427-915fda50f088@FreeBSD.org>

index | next in thread | previous in thread | raw e-mail

On 4/21/26 10:39, Kyle Evans wrote:
> On 4/21/26 10:29, Warner Losh wrote:
>>
>>
>> On Tue, Apr 21, 2026 at 9:12 AM Warner Losh <imp@bsdimp.com <mailto:imp@bsdimp.com>> wrote:
>>
>>
>>
>>     On Tue, Apr 21, 2026 at 7:51 AM Ed Maste <emaste@freebsd.org <mailto:emaste@freebsd.org>> wrote:
>>
>>         On Fri, 17 Apr 2026 at 22:43, Warner Losh <imp@freebsd.org <mailto:imp@freebsd.org>> wrote:
>>          >
>>          > The branch main has been updated by imp:
>>          >
>>          > URL: https://cgit.FreeBSD.org/src/commit/?id=4ed20e0236dd0ce64aa4d79659288a56e1b1344b <https://cgit.FreeBSD.org/src/commit/?id=4ed20e0236dd0ce64aa4d79659288a56e1b1344b>;
>>          >
>>          > commit 4ed20e0236dd0ce64aa4d79659288a56e1b1344b
>>          > Author:     Warner Losh <imp@FreeBSD.org>
>>          > AuthorDate: 2026-04-18 02:41:26 +0000
>>          > Commit:     Warner Losh <imp@FreeBSD.org>
>>          > CommitDate: 2026-04-18 02:41:43 +0000
>>          >
>>          >     kshim/usb: Add build option.
>>          >
>>          >     Add WITH{,OUT}_LOADER_USB to build the kshim usb library. Nothing
>>          >     in-tree uses it, but this will make it easier to keep building. Updated
>>          >     src.conf.5 with a few extra changes...
>>          >
>>          >     Sponsored by:           Netflix
>>          > ---
>>          >  share/man/man5/src.conf.5           | 445 +++++++++++++++++++++++++++++++++++-
>>          >  share/mk/src.opts.mk <http://src.opts.mk>                |   3 +-
>>          >  stand/Makefile                      |   1 +
>>          >  tools/build/options/WITH_LOADER_USB |   2 +
>>          >  4 files changed, 443 insertions(+), 8 deletions(-)
>>          >
>>          > diff --git a/share/man/man5/src.conf.5 b/share/man/man5/src.conf.5
>>          > index 65fbcf2e69a4..79f75d87e3d5 100644
>>          > --- a/share/man/man5/src.conf.5
>>          > +++ b/share/man/man5/src.conf.5
>>          > @@ -1,5 +1,5 @@
>>          >  .\" DO NOT EDIT-- this file is @generated by tools/build/options/makeman.
>>          > -.Dd April 10, 2026
>>          > +.Dd April 17, 2026
>>          >  .Dt SRC.CONF 5
>>          >  .Os
>>          >  .Sh NAME
>>          > @@ -121,6 +121,8 @@ When set, it enforces these options:
>>          >  .Pp
>>          >  .Bl -item -compact
>>          >  .It
>>          > +.Va WITH_CASPER
>>
>>         What's with the spurious WITH_CASPER additions? When I run `make
>>         makeman` on main these are all removed again.
>>
>>
>>     I'm not sure. Let me re-run this when I sort the args.
>>
>>
>> Oh my! It's a bug in makeman.lua. makeman doesn't do it, while makeman.lua does.
>>
>> Warner
> 
> Well that's awkward. :-)  I thought the only differences it still had were from running it on arm64 locally here... I'll take a look.
> 

Ah, apparently I might have had a fix for this locally- I just posted https://reviews.freebsd.org/D56558 that should fix it and switch the top-level `makeman` target.

Thanks,

Kyle Evans


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?10843b7c-32af-404e-820c-100f8b863abb>