Date: Mon, 31 Jul 2023 20:15:59 +0200 From: Daniel Engberg <diizzy@FreeBSD.org> To: "Jason E. Hale" <jhale@freebsd.org> Cc: Vladimir Druzenko <vvd@freebsd.org>, Charlie Li <vishwin@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 7ebddd96d372 - main - multimedia/mlt7*: Update to 7.18.0 Message-ID: <acac6bb666d9ff01686c10e0e1463eb9@FreeBSD.org> In-Reply-To: <CAJE75NFTRVon=0=7xSVZ7V0yUPXNPX47ek=suj0rUSCPdFirJg@mail.gmail.com> References: <202307302015.36UKFpFO036109@gitrepo.freebsd.org> <39e34dfa-db88-0b05-6ae1-02137701dd9d@freebsd.org> <21e21bfd-e0e2-f3d8-2f7c-34333f2c94dd@freebsd.org> <fa3c4450-5ffe-95a3-37bc-8b49dc5df7e1@freebsd.org> <5afa5396-12f2-baa7-573a-6608225c25b2@freebsd.org> <dd4e4037e3f80898a6e4db29fba51a66@pyret.net> <0a630993-2521-e330-02dd-606ac146b91a@freebsd.org> <CAJE75NFTRVon=0=7xSVZ7V0yUPXNPX47ek=suj0rUSCPdFirJg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2023-07-31 17:37, Jason E. Hale wrote: > On Sun, Jul 30, 2023 at 9:15 PM Vladimir Druzenko <vvd@freebsd.org> > wrote: >> >> 31.07.2023 03:02, Daniel Engberg пишет: >> > On 2023-07-31 01:45, Charlie Li wrote: >> >> Vladimir Druzenko wrote: >> >>> It's very big dependency. I can create patch for multimedia/mlt7 >> >>> with choice which libebur128 to use: 1) huge external on rust or 2) >> >>> small internal on C. >> >>> >> >> There is no rust code anywhere in audio/libebur128 or its >> >> dependencies. So don't even think about it any further. >> >> >> >> Furthermore, MLT and its consumers are not designed or intended to be >> >> used in insufficiently-resourced computing environments. >> > >> > We actually have two implementations available in tree, >> > >> > audio/ebur128 and audio/libebur128 >> > >> > audio/ebur128 is a Rust implementation that performs noticably better >> > and we moved all consumers almost 3 months ago to that variant. >> > https://cgit.freebsd.org/ports/commit/?id=4cd440845e24202042e8b35a1c1db08a928b5946 >> > >> > >> > Worth mentioning is that it's only a build dependency >> > >> > Best regards, >> > Daniel >> >> > If there's a need further down the road we can add an option to choose >> > between. >> The need has arisen. >> > > I think the most sensible approach would be to handle the ebur128 > dependency similar to librsvg2 and pycryptography. It would be trivial > to create a Mk/Uses/ebur128.mk and allow the user to set whether they > wanted to use the legacy C implementation via DEFAULT_VERSIONS in > /etc/make.conf. The rust version would still be the default, however. > Does that sound like an agreeable solution? > > -Jason While that would be the correct way of handling multiple conflicting libraries I just think it adds unnecessary complexity to very little benefit as I don't see the issue since its a build dependency. Poudriere does also support overlay if you want to modify the tree with local patches. Best regards, Daniel
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?acac6bb666d9ff01686c10e0e1463eb9>