Date: Sat, 09 Jul 2005 01:03:22 +0400 From: Roman Kurakin <rik@cronyx.ru> To: Maxim Sobolev <sobomax@portaone.com> Cc: Roman Kurakin <rik@FreeBSD.ORG>, cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/compat/ndis subr_ntoskrnl.c Message-ID: <42CEEA1A.8090903@cronyx.ru> In-Reply-To: <42CECCD8.5070201@portaone.com> References: <200507081837.j68Ib0IM082223@repoman.freebsd.org> <42CECCD8.5070201@portaone.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Maxim Sobolev: > Roman Kurakin wrote: > >> rik 2005-07-08 18:36:59 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/compat/ndis subr_ntoskrnl.c Log: >> Use implicit type cast for ->k_lock to fix compilation of ndis >> as a part of the GENERIC kernel with INVARIANT* and WITNESS* >> turned off. > > I think the better fix is to change type of k_lock member from void* > to the struct mtx*, Probably. I didn't try to find out the reason why it is void *. Probably there was some reasons. I just leave it as is. > I've already commited such change to the RELENG_5 few days ago. Hm. I've checked my mailbox and you commit was marked as unread that means "to check it". If you are sure that there is no any special reason why it is void* (other locks are normal) it worth to fix it your way. rik > -Maxim
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?42CEEA1A.8090903>