Date: Fri, 6 Sep 2019 07:15:17 -0700 From: Steve Kargl <sgk@troutmask.apl.washington.edu> To: Stefan Kanthak <stefan.kanthak@nexgo.de> Cc: freebsd-numerics@freebsd.org, das@freebsd.org Subject: Re: Superfluous instructions in crufty old releng/12.0/lib/msun/i387/s_remquo.S, releng/12.0/lib/msun/amd64/s_remquo.S, ... Message-ID: <20190906141517.GA91272@troutmask.apl.washington.edu> In-Reply-To: <582553CAF6B647A09A15C24F50B9A75E@H270> References: <582553CAF6B647A09A15C24F50B9A75E@H270>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Sep 06, 2019 at 12:45:03PM +0200, Stefan Kanthak wrote: > > although I doubt that this FPU code might still be used, > here's a patch to shave 2 superfluous instructions from > http://sources.freebsd.org/releng/12.0/lib/msun/i387/s_remquo.S > http://sources.freebsd.org/releng/12.0/lib/msun/i387/s_remquof.S > http://sources.freebsd.org/releng/12.0/lib/msun/i387/s_remquol.S > http://sources.freebsd.org/releng/12.0/lib/msun/amd64/s_remquo.S > http://sources.freebsd.org/releng/12.0/lib/msun/amd64/s_remquof.S > http://sources.freebsd.org/releng/12.0/lib/msun/amd64/s_remquol.S > I don't know assembly, so cannot judge the correctness of your patch. Perhaps, bde will chime in here. The files are used. % make |& tee make.txt ... cc -O2 -pipe -I/usr/src/lib/msun/x86 -I/usr/src/lib/msun/ld80 -I/usr/src/lib/msun/i387 -I/usr/src/lib/msun/src -I/usr/src/lib/libc/include -I/usr/src/lib/libc/i386 -march=core2 -MD -MF.depend.s_remquo.o -MTs_remquo.o -std=gnu99 -fstack-protector-strong -Wsystem-headers -Werror -Wno-pointer-sign -Wno-unknown-pragmas -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable -Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality -Wno-unused-function -Wno-enum-conversion -Wno-unused-local-typedef -Wno-address-of-packed-member -Wno-switch -Wno-switch-enum -Wno-knr-promoted-parameter -Wno-parentheses -Qunused-arguments -c /usr/src/lib/msun/i387/s_remquo.S -o s_remquo.o -- Steve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190906141517.GA91272>