Date: Tue, 26 Sep 2023 11:56:45 -0600 From: Warner Losh <imp@bsdimp.com> To: Jessica Clarke <jrtc27@freebsd.org> Cc: Ravi Pokala <rpokala@freebsd.org>, Mateusz Guzik <mjg@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org> Subject: Re: e6dc6a27230f - main - sys/conf/newvers.sh: whack sccs tag Message-ID: <CANCZdfob=dkXL-5Oc4dsr1jNHnWjoW1TVrP2ogAPGgRnDGv09w@mail.gmail.com> In-Reply-To: <FA6AAA38-C132-44A8-9FE4-7365FA41980A@freebsd.org> References: <202309261437.38QEbWmw002059@gitrepo.freebsd.org> <CANCZdformxVqA0LjzOpWosgd-RUCP0r3UE=4rk9W0E6pGOGRfA@mail.gmail.com> <52507A54-AAB7-43E9-BD06-41B9C78CF296@panasas.com> <FA6AAA38-C132-44A8-9FE4-7365FA41980A@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--00000000000002461d060646cd51 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Sep 26, 2023 at 11:34=E2=80=AFAM Jessica Clarke <jrtc27@freebsd.org= > wrote: > On 26 Sep 2023, at 18:32, Ravi Pokala <rpokala@freebsd.org> wrote: > > > > In that case, an updated comment seems appropriate, so it=E2=80=99s not= removed > again. > > https://reviews.freebsd.org/D41984 Jessica beat me to it. I have a back out and this commit queued up. I've just updated the comment. I'm not at all happy with it yet. The details are in the commit message, but the tl;dr is that while we do write the version to the end of the dumps, savecore doesn't preserve that when writing vmcore.X, so to identify what kernel a dump is from reliably, one must use the SCCS ID tags. Trying to find other strings to get this data is not as reliable. The real fix for this issue with the vmcore.X format is to write ELF core dumps, a feature vaguely planned for 15, where we can save this data in a way that can be extracted with scripts. Warner > > > -Ravi (rpokala@) > > > > From: <owner-src-committers@freebsd.org> on behalf of Warner Losh < > imp@bsdimp.com> > > Date: Tuesday, September 26, 2023 at 07:51 > > To: Mateusz Guzik <mjg@freebsd.org> > > Cc: src-committers <src-committers@freebsd.org>, "< > dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "< > dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org> > > Subject: Re: git: e6dc6a27230f - main - sys/conf/newvers.sh: whack sccs > tag > > > > Can you put this back? It is still useful. I have automated scripts > that look for this pattern to find the version of a core dump. There are = no > other ways that are as reliable to find this data. Some other heuristics > exist, but my experience with snagging data from maybe a thousand core > dumps from $WORK's network found issues in all the alternatives. It's why= I > didn't whack it already. Even though the text says SCCS which is prehisto= ry > for this project, it's still in use today. > > Warner > > > > On Tue, Sep 26, 2023, 8:37 AM Mateusz Guzik <mjg@freebsd.org> wrote: > >> > >> > >> The branch main has been updated by mjg: > >> > >> URL: > https://cgit.FreeBSD.org/src/commit/?id=3De6dc6a27230f836a131118326731b7c= 5fd417723 > >> > >> commit e6dc6a27230f836a131118326731b7c5fd417723 > >> Author: Mateusz Guzik <mjg@FreeBSD.org> > >> AuthorDate: 2023-09-26 14:36:51 +0000 > >> Commit: Mateusz Guzik <mjg@FreeBSD.org> > >> CommitDate: 2023-09-26 14:36:51 +0000 > >> > >> sys/conf/newvers.sh: whack sccs tag > >> > >> In the same spirit as removing cvs $FreeBSD$ tags. > >> > >> Sponsored by: Rubicon Communications, LLC ("Netgate") > >> --- > >> sys/conf/newvers.sh | 2 -- > >> 1 file changed, 2 deletions(-) > >> > >> diff --git a/sys/conf/newvers.sh b/sys/conf/newvers.sh > >> index 73fd6857d307..18b1817ca287 100644 > >> --- a/sys/conf/newvers.sh > >> +++ b/sys/conf/newvers.sh > >> @@ -311,11 +311,9 @@ fi > >> > >> vers_content_new=3D$(cat << EOF > >> $COPYRIGHT > >> -#define SCCSSTR "@(#)${VERINFO}" > >> #define VERSTR "${VERSTR}" > >> #define RELSTR "${RELEASE}" > >> > >> -char sccs[sizeof(SCCSSTR) > 128 ? sizeof(SCCSSTR) : 128] =3D SCCSSTR; > >> char version[sizeof(VERSTR) > 256 ? sizeof(VERSTR) : 256] =3D VERSTR; > >> char compiler_version[] =3D "${compiler_v}"; > >> char ostype[] =3D "${TYPE}"; > > --00000000000002461d060646cd51 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">= <div dir=3D"ltr" class=3D"gmail_attr">On Tue, Sep 26, 2023 at 11:34=E2=80= =AFAM Jessica Clarke <<a href=3D"mailto:jrtc27@freebsd.org">jrtc27@freeb= sd.org</a>> wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"m= argin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left= :1ex">On 26 Sep 2023, at 18:32, Ravi Pokala <<a href=3D"mailto:rpokala@f= reebsd.org" target=3D"_blank">rpokala@freebsd.org</a>> wrote:<br> > <br> > In that case, an updated comment seems appropriate, so it=E2=80=99s no= t removed again.<br> <br> <a href=3D"https://reviews.freebsd.org/D41984" rel=3D"noreferrer" target=3D= "_blank">https://reviews.freebsd.org/D41984</a></blockquote><div><br></div>= <div>Jessica beat me to it. I have a back out and this commit queued up. I&= #39;ve just</div><div>updated the comment. I'm not at all happy with it= yet.</div><div><br></div><div>The details are in the commit message, but t= he tl;dr is that while we do write</div><div>the version to the end of the = dumps, savecore doesn't preserve that when</div><div>writing vmcore.X, = so to identify what kernel a dump is from reliably, one</div><div>must use = the SCCS ID tags. Trying to find other strings to get this data is</div><di= v>not as reliable.</div><div><br></div><div>The real fix for this issue wit= h the vmcore.X format is to write ELF core</div><div>dumps, a feature vague= ly planned for 15, where we can save this data</div><div>in a way that can = be extracted with scripts.</div><div><br></div><div>Warner</div><div>=C2=A0= </div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;b= order-left:1px solid rgb(204,204,204);padding-left:1ex"><br> >=C2=A0 -Ravi (rpokala@)<br> > <br> > From: <<a href=3D"mailto:owner-src-committers@freebsd.org" target= =3D"_blank">owner-src-committers@freebsd.org</a>> on behalf of Warner Lo= sh <<a href=3D"mailto:imp@bsdimp.com" target=3D"_blank">imp@bsdimp.com</= a>><br> > Date: Tuesday, September 26, 2023 at 07:51<br> > To: Mateusz Guzik <<a href=3D"mailto:mjg@freebsd.org" target=3D"_bl= ank">mjg@freebsd.org</a>><br> > Cc: src-committers <<a href=3D"mailto:src-committers@freebsd.org" t= arget=3D"_blank">src-committers@freebsd.org</a>>, "<<a href=3D"m= ailto:dev-commits-src-all@freebsd.org" target=3D"_blank">dev-commits-src-al= l@freebsd.org</a>>" <<a href=3D"mailto:dev-commits-src-all@freeb= sd.org" target=3D"_blank">dev-commits-src-all@freebsd.org</a>>, "&l= t;<a href=3D"mailto:dev-commits-src-main@freebsd.org" target=3D"_blank">dev= -commits-src-main@freebsd.org</a>>" <<a href=3D"mailto:dev-commi= ts-src-main@freebsd.org" target=3D"_blank">dev-commits-src-main@freebsd.org= </a>><br> > Subject: Re: git: e6dc6a27230f - main - sys/conf/newvers.sh: whack scc= s tag<br> > <br> >=C2=A0 Can you put this back? It is still useful. I have automated scri= pts that look for this pattern to find the version of a core dump. There ar= e no other ways that are as reliable to find this data. Some other heuristi= cs exist, but my experience with snagging data from maybe a thousand core d= umps from $WORK's network found issues in all the alternatives. It'= s why I didn't whack it already. Even though the text says SCCS which i= s prehistory for this project, it's still in use today.<br> >=C2=A0 Warner<br> > <br> > On Tue, Sep 26, 2023, 8:37 AM Mateusz Guzik <<a href=3D"mailto:mjg@= freebsd.org" target=3D"_blank">mjg@freebsd.org</a>> wrote:<br> >> <br> >> <br> >> The branch main has been updated by mjg:<br> >> <br> >> URL: <a href=3D"https://cgit.FreeBSD.org/src/commit/?id=3De6dc6a27= 230f836a131118326731b7c5fd417723" rel=3D"noreferrer" target=3D"_blank">http= s://cgit.FreeBSD.org/src/commit/?id=3De6dc6a27230f836a131118326731b7c5fd417= 723</a><br> >> <br> >> commit e6dc6a27230f836a131118326731b7c5fd417723<br> >> Author:=C2=A0 =C2=A0 =C2=A0Mateusz Guzik <mjg@FreeBSD.org><b= r> >> AuthorDate: 2023-09-26 14:36:51 +0000<br> >> Commit:=C2=A0 =C2=A0 =C2=A0Mateusz Guzik <mjg@FreeBSD.org><b= r> >> CommitDate: 2023-09-26 14:36:51 +0000<br> >> <br> >>=C2=A0 =C2=A0 =C2=A0sys/conf/newvers.sh: whack sccs tag<br> >> <br> >>=C2=A0 =C2=A0 =C2=A0In the same spirit as removing cvs $FreeBSD$ ta= gs.<br> >> <br> >>=C2=A0 =C2=A0 =C2=A0Sponsored by:=C2=A0 =C2=A0Rubicon Communication= s, LLC ("Netgate")<br> >> ---<br> >>=C2=A0 sys/conf/newvers.sh | 2 --<br> >>=C2=A0 1 file changed, 2 deletions(-)<br> >> <br> >> diff --git a/sys/conf/newvers.sh b/sys/conf/newvers.sh<br> >> index 73fd6857d307..18b1817ca287 100644<br> >> --- a/sys/conf/newvers.sh<br> >> +++ b/sys/conf/newvers.sh<br> >> @@ -311,11 +311,9 @@ fi<br> >> <br> >>=C2=A0 vers_content_new=3D$(cat << EOF<br> >>=C2=A0 $COPYRIGHT<br> >> -#define SCCSSTR "@(#)${VERINFO}"<br> >>=C2=A0 #define VERSTR "${VERSTR}"<br> >>=C2=A0 #define RELSTR "${RELEASE}"<br> >> <br> >> -char sccs[sizeof(SCCSSTR) > 128 ? sizeof(SCCSSTR) : 128] =3D S= CCSSTR;<br> >>=C2=A0 char version[sizeof(VERSTR) > 256 ? sizeof(VERSTR) : 256]= =3D VERSTR;<br> >>=C2=A0 char compiler_version[] =3D "${compiler_v}";<br> >>=C2=A0 char ostype[] =3D "${TYPE}";<br> <br> </blockquote></div></div> --00000000000002461d060646cd51--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfob=dkXL-5Oc4dsr1jNHnWjoW1TVrP2ogAPGgRnDGv09w>