Date: Thu, 11 Nov 2010 14:45:42 +0100 From: Joerg.Schilling@fokus.fraunhofer.de (Joerg Schilling) To: mav@FreeBSD.org Cc: freebsd-scsi@FreeBSD.org, freebsd-current@FreeBSD.org, freebsd-stable@FreeBSD.org, marius@alchemy.franken.de Subject: Re: Sense fetching [Was: cdrtools /devel ...] Message-ID: <4cdbf386.cAc%2BPtgM%2B41jseN5%Joerg.Schilling@fokus.fraunhofer.de> In-Reply-To: <4CDBEF8D.5080001@FreeBSD.org> References: <4CD45209.5010607@FreeBSD.org> <20101105192028.GA68728@alchemy.franken.de> <4cd822df.o/wBtwsNCXiy8xZn%Joerg.Schilling@fokus.fraunhofer.de> <4CD82E2A.3070407@FreeBSD.org> <4cd8320a.U7/OjtLLBVtE4dTy%Joerg.Schilling@fokus.fraunhofer.de> <4CD83535.1010008@FreeBSD.org> <4cdbbfef.v4cr/k2jZr9gdpyF%Joerg.Schilling@fokus.fraunhofer.de> <4CDBC55B.1040307@FreeBSD.org> <4cdbc65f.bo%2BmYNFB2GPwXmq7%Joerg.Schilling@fokus.fraunhofer.de> <4CDBEA8B.1020306@FreeBSD.org> <4cdbece1.EWYSqdvnx6XWF8EF%Joerg.Schilling@fokus.fraunhofer.de> <4CDBEF8D.5080001@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Alexander Motin <mav@FreeBSD.org> wrote:
> > What is the requested size with the various HBAs in earlier kernels?
>
> For HBAs with automatic sense fetching -- as passed in sence_len request
> field. In case of libscg it was SSD_FULL_SIZE before and I've set it to
> be real value now. Returned sense_resid should be real in both cases,
> respecting submitted sense_len.
>
> For HBAs without sense fetching, CAM was always requesting SSD_FULL_SIZE
> and returned fake zero sense_resid, like if it just completely fulfilled
> sense_len from request. Now it should start honor sense_len on request
> and return real sense_resid on reply, relative to sense_len.
Then your patch to libscg seems to be OK and without risk.
Jörg
--
EMail:joerg@schily.isdn.cs.tu-berlin.de (home) Jörg Schilling D-13353 Berlin
js@cs.tu-berlin.de (uni)
joerg.schilling@fokus.fraunhofer.de (work) Blog: http://schily.blogspot.com/
URL: http://cdrecord.berlios.de/private/ ftp://ftp.berlios.de/pub/schily
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4cdbf386.cAc%2BPtgM%2B41jseN5%Joerg.Schilling>