Date: Mon, 14 Jan 2008 17:32:39 -0500 From: David Schultz <das@FreeBSD.ORG> To: Kris Kennaway <kris@FreeBSD.ORG> Cc: Tim Kientzle <tim@kientzle.com>, src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, obrien@FreeBSD.ORG, Tim Kientzle <kientzle@FreeBSD.ORG>, cvs-all@FreeBSD.ORG, Dag-Erling Smorgrav <des@FreeBSD.ORG> Subject: Re: cvs commit: src/usr.bin/unzip Makefile unzip.1 unzip.c Message-ID: <20080114223239.GC56062@VARK.MIT.EDU> In-Reply-To: <478BC55B.2060202@FreeBSD.org> References: <200801080800.m08806jI012963@repoman.freebsd.org> <478A8FFE.8080602@freebsd.org> <478A95F2.1070709@FreeBSD.org> <478AA9E4.2010807@kientzle.com> <478ABC4B.8080601@FreeBSD.org> <20080114181154.GA2286@dragon.NUXI.org> <478BC55B.2060202@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jan 14, 2008, Kris Kennaway wrote: > David O'Brien wrote: > > >>If we have to special case ports to deal with variant zipfiles that > >>cannot be processed by /usr/bin/unzip then it gets messier because we > >>have to account for some ports being satisfied with USE_ZIP=yes meaning > >>/usr/bin/unzip and some still requiring /usr/ports/archivers/unzip. I'd > >>prefer not to have to add those workarounds. > > > >This seems quite easy... > > > >For those four-ish ports 's/USE_ZIP/USE_INFOZIP/' > > That's what I meant by "special case". I don't like adding special case > variables to bsd.*.mk for the benefit of a tiny number of ports; that > file is already cluttered enough. Given how little time it took Tim to get libarchive from a simple prototype that supported tar files to a 23k line library that supports dozens of variant archive formats, I suspect that the limitation and the corresponding hack will be temporary. :) And if it is just a small number of ports, it could be set up as an extract dependency in the individual port makefiles, right? It's not as though InfoZIP is going to change a lot in the near future.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080114223239.GC56062>