Date: Tue, 27 Jan 2004 15:57:53 +0100 From: Pawel Jakub Dawidek <nick@garage.freebsd.pl> To: Lukas Ertl <l.ertl@univie.ac.at> Cc: freebsd-geom@freebsd.org Subject: Re: Error checking for g_mod_event() and friends Message-ID: <20040127145753.GM565@garage.freebsd.pl> In-Reply-To: <20040127154303.E92925@pcle2.cc.univie.ac.at> References: <20040127154303.E92925@pcle2.cc.univie.ac.at>
next in thread | previous in thread | raw e-mail | index | archive | help
--AQNmCumFClRcGgHG Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 27, 2004 at 03:46:30PM +0100, Lukas Ertl wrote: +> is there a specific reason that the .init function of a class is declared +> to return "void"? I'd like to change that to an int, so we could do err= or +> checking, and subsequently modify g_load_class() to check for errors and +> so on. Look at: http://garage.freebsd.pl/patches/geom_subr.c.patch The biggest problem is that g_event thread is created after classes are loaded, so we end up with deadlock on boot. +> Additionally, I've seen several calls to g_malloc() where the return +> values aren't checked - should I prepare some patches for these? I don't see any g_malloc() call with M_NOWAIT. --=20 Pawel Jakub Dawidek pawel@dawidek.net UNIX Systems Programmer/Administrator http://garage.freebsd.pl Am I Evil? Yes, I Am! http://cerber.sourceforge.net --AQNmCumFClRcGgHG Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (FreeBSD) iQCVAwUBQBZ8cT/PhmMH/Mf1AQG+rwQAg2DLwd4CakKZTPFTP8+cgE3hS4RPFlxV nN6F6KM+IYVwuTgDCVJ1RP2fJg+KksphVCJOHN2g8UlWkLJIr7HfTi3Y+/cu8i04 9NVbuIPwcQ5P0QRNy83vSAbZPDeG9I2wxdjqv/4s5wekzEQL5ZmxmxhLstiCgez9 6nRFYv//PWk= =vIFh -----END PGP SIGNATURE----- --AQNmCumFClRcGgHG--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040127145753.GM565>