Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 28 Apr 2024 20:44:44 +0200
From:      Jan Beich <jbeich@FreeBSD.org>
To:        Florian Smeets <flo@FreeBSD.org>
Cc:        Emanuel Haupt <ehaupt@FreeBSD.org>, Nuno Teixeira <eduardo@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject:   Re: git: 4ab6c1871671 - main - */*: Remove GNU_CONFIGURE_MANPREFIX
Message-ID:  <y18x-jpib-wny@FreeBSD.org>
In-Reply-To: <9dc94105-846e-44c9-a32a-8409dbb0c3e1@FreeBSD.org> (Florian Smeets's message of "Sun, 28 Apr 2024 17:06:49 %2B0200")
References:  <202404121936.43CJa5vU012745@gitrepo.freebsd.org> <CAFDf7UJ1xcJLL5t%2BK6VGtN7T4vA9a4TtoRR9pr2N34EcRUO85g@mail.gmail.com> <20240428144959.4fe9e4e0ca163f1dc7b4788a@FreeBSD.org> <CAFDf7UJnTDD61vBmPsYDXsgxje1AxLp7XKJYNeAF0omQP4Os_w@mail.gmail.com> <20240428152014.a3dc14906b9df118bcc84d34@FreeBSD.org> <9dc94105-846e-44c9-a32a-8409dbb0c3e1@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Florian Smeets <flo@FreeBSD.org> writes:

> On 28.04.24 15:20, Emanuel Haupt wrote:
>
>> Nuno Teixeira <eduardo@freebsd.org> wrote:
>>> Ok, I understand it as I misunderstood 2024Q2 was including manprefix
>>> update.
>>>
>>> But taking your commit as an example, since manprefix fix was removed
>>> from all your ports what happens if you need a cherry-pick to
>>> quarterly in the future?
>> As I said, I'd manually copy the files from main, make the necessary
>> modifications (i.e., specify GNU_CONFIGURE_MANPREFIX), and then perform
>> a git commit/push with sufficient references explaining why.
>> 
>
> Yes, you would need to do a direct commit, and explain why it's
> necessary. It should be handled the same as in src, so no approval is
> required or anything. Just exercise caution and have a rationale.
>
> See cbaccc953d55 and 7555ec6eeba0 for examples.

Would be nice to standardize direct commit annotation. For example,
during Subversion days I've appended "(direct commit)" to summary line
and during Git days mimicked "git cherry-pick -x" footer.

$ for b in $(git branch --remote -l origin/\*Q\*); do
    PAGER=cat git log --oneline --committer=jbeich --grep="direct commit" $b;
  done | wc -l
23



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?y18x-jpib-wny>