Date: Wed, 7 Sep 2022 11:56:04 +0200 From: =?UTF-8?B?VMSzbA==?= Coosemans <tijl@FreeBSD.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: Colin Percival <cperciva@tarsnap.com>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-branches@freebsd.org Subject: Re: git: 5d45f99a1ed8 - stable/13 - i386 doreti: Fix calculation of stack frame size Message-ID: <20220907115604.6e5fbfeb@FreeBSD.org> In-Reply-To: <YxeA6Y4lD/5DXfcJ@kib.kiev.ua> References: <202209021506.282F6Jhx029847@gitrepo.freebsd.org> <01000182feec990a-943b1465-055b-4cb8-984c-225a4feabf7d-000000@email.amazonses.com> <20220906172225.1a4d1064@FreeBSD.org> <YxeA6Y4lD/5DXfcJ@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 6 Sep 2022 20:18:33 +0300 Konstantin Belousov <kostikbel@gmail.com> wrote: > On Tue, Sep 06, 2022 at 05:22:25PM +0200, T=C4=B3l Coosemans wrote: >> On Fri, 2 Sep 2022 15:58:14 +0000 Colin Percival <cperciva@tarsnap.com> >> wrote: =20 >>> On 9/2/22 08:06, Tijl Coosemans wrote: =20 >>>> The branch stable/13 has been updated by tijl: >>>>=20 >>>> URL: https://cgit.FreeBSD.org/src/commit/?id=3D5d45f99a1ed861618d5c4d5= b4252d5eba001ad35 >>>>=20 >>>> commit 5d45f99a1ed861618d5c4d5b4252d5eba001ad35 >>>> Author: Tijl Coosemans <tijl@FreeBSD.org> >>>> AuthorDate: 2022-09-02 14:16:35 +0000 >>>> Commit: Tijl Coosemans <tijl@FreeBSD.org> >>>> CommitDate: 2022-09-02 15:02:00 +0000 >>>>=20 >>>> i386 doreti: Fix calculation of stack frame size >>>> =20 >>>> Reviewed by: kib >>>> Fixes: e8b2980e4a12 - i386 doreti: stop saving/restoring= %ecx >>>> =20 >>>> (cherry picked from commit cfdc649e455bc0d37d42c46b59360462e93b43= 00) =20 >>> I assume this MFC took place 23 minutes after the original commit becau= se it >>> was an urgent fix; to avoid the need for assumptions, please indicate t= he >>> reason for an accelerated MFC in the commit message when you skip the n= ormal >>> 3 day waiting period. =20 >>=20 >> Will do. In this case it was a trivial fixup in a critical path. At the >> time I also thought it fixed a panic I was seeing but this turned out to >> be caused by another commit. =20 >=20 > It is not on critical path, at worst it affected vm86 mode only. > That said, 'the other bug' was there before the series. Looking into this again I now believe your change was actually correct. trampstk =3D (uintptr_t)tramp_stack_base + TRAMP_STACK_SZ - VM86_STACK_SPACE So it already has VM86_STACK_SPACE subtracted. Can you double-check this?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20220907115604.6e5fbfeb>