Date: Tue, 18 Jun 2013 10:02:57 +0200 From: Tijl Coosemans <tijl@FreeBSD.org> To: Ed Schouten <ed@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r251804 - head/sys/sys Message-ID: <51C01431.8070600@FreeBSD.org> In-Reply-To: <201306161048.r5GAmmkG082610@svn.freebsd.org> References: <201306161048.r5GAmmkG082610@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 2013-06-16 12:48, Ed Schouten wrote: > Author: ed > Date: Sun Jun 16 10:48:47 2013 > New Revision: 251804 > URL: http://svnweb.freebsd.org/changeset/base/251804 > > Log: > Move _Atomic() into <sys/cdefs.h>. > > That way _Atomic() is defined next to all the other C11 keywords for > which we provide compatibility for pre-C11 compilers. While there, fix > the definition to place "volatile" at the end. Otherwise pointer types > will become "volatile T *" instead of "T * volatile". Do you even need volatile? It seems the only place this has an effect is initialisation, but there's not supposed to be any concurrent access then, meaning the value isn't volatile at that point. [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (FreeBSD) iF4EAREIAAYFAlHAFDcACgkQfoCS2CCgtivUaQD/VZgkOWorJJc49cX6KR3r1LWE qTvxX5OG8ZP7dgh54AIA/3+bSY9botZqO5Xim42fIJLonrVlGEMlaTKKimfTOydF =OyJs -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51C01431.8070600>