Date: Thu, 01 Sep 2005 17:16:21 +0900 (JST) From: Kazuhito HONDA <kazuhito@ph.noda.tus.ac.jp> To: skywizard@MyBSD.org.my Cc: freebsd-multimedia@freebsd.org Subject: Re: Sound patches and volume problems? Message-ID: <20050901.171621.343192221.kazuhito@ph.noda.tus.ac.jp> In-Reply-To: <20050829072613.3eb2b46e.skywizard@MyBSD.org.my> References: <20050828234613.3e8b063a.torfinn.ingolfsen@broadpark.no> <20050829072613.3eb2b46e.skywizard@MyBSD.org.my>
next in thread | previous in thread | raw e-mail | index | archive | help
Hello,
From: Ariff Abdullah <skywizard@MyBSD.org.my>
Subject: Re: Sound patches and volume problems?
Date: Mon, 29 Aug 2005 07:26:13 +0800
> but I do suspect it's all about incorrect volume resolution or
> perhaps volume miscalculation within uaudio.c.
Ah, though it may not be related to that problem,
uaudio.c has one bug about volume calculation at least.
This sometimes gives a USB audio device an unexpected value.
But this doesn't affect when the volume is small.
Sincerely yours
kazuhito HONDA
kazuhito@ph.noda.tus.ac.jp
--- uaudio.c.orig Thu Sep 1 16:51:34 2005
+++ uaudio.c Thu Sep 1 16:52:13 2005
@@ -4130,10 +4130,10 @@ uaudio_mixer_set(device_t dev, unsigned
if (mc->ctl == type) {
if (mc->nchan == 2) {
/* set Right */
- uaudio_ctl_set(sc, SET_CUR, mc, 1, (int)(right*256)/100);
+ uaudio_ctl_set(sc, SET_CUR, mc, 1, (int)(right*255)/100);
}
/* set Left or Mono */
- uaudio_ctl_set(sc, SET_CUR, mc, 0, (int)(left*256)/100);
+ uaudio_ctl_set(sc, SET_CUR, mc, 0, (int)(left*255)/100);
}
}
return;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050901.171621.343192221.kazuhito>