Date: Thu, 19 Jul 2001 12:17:58 -0700 (PDT) From: Matt Dillon <dillon@earth.backplane.com> To: Ruslan Ermilov <ru@FreeBSD.ORG> Cc: Assar Westerlund <assar@FreeBSD.ORG>, security@FreeBSD.ORG Subject: Re: [PATCH] Re: FreeBSD remote root exploit ? Message-ID: <200107191917.f6JJHwV77405@earth.backplane.com> References: <5.1.0.14.0.20010719001357.03e22638@192.168.0.12> <014d01c11031$bdab5a10$2001a8c0@clitoris> <20010719201407.B61061@sunbay.com> <003701c11077$b3125400$0d00a8c0@alexus> <3B5718A0.2B650C9C@oksala.org> <200107191752.f6JHqer75736@earth.backplane.com> <20010719205948.D67829@sunbay.com> <200107191817.f6JIHSJ76262@earth.backplane.com> <20010719215957.A74024@sunbay.com>
next in thread | previous in thread | raw e-mail | index | archive | help
:>
:> The output_data() calls for the various options are safe, strlen(format)
:> will always be larger then the actual formatted result. But the
:> debugging and crypto calls to output_data() are not safe.
:>
:> -Matt
:>
:> : netflush();
:> : remaining = BUFSIZ - (nfrontp - netobuf);
:> : }
:> : ret = vsnprintf(nfrontp, remaining, format, args);
:>
:Should be fixed in state.c,v 1.7. Thanks, Assar!
:
:
:Cheers,
:--
:Ruslan Ermilov Oracle Developer/DBA,
:ru@sunbay.com Sunbay Software AG,
heh heh. Sorry guys, state.c still isn't quite right.
nfrontp += ((ret < remaining - 1) ? ret : remaining - 1);
What happens if remaining is 0 ?
-Matt
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-security" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200107191917.f6JJHwV77405>