Date: Thu, 2 Dec 2010 03:53:29 +0000 (UTC) From: Pyun YongHyeon <yongari@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/sys/dev/fxp if_fxp.c Message-ID: <201012020353.oB23rjuk034404@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
yongari 2010-12-02 03:53:29 UTC
FreeBSD src repository
Modified files:
sys/dev/fxp if_fxp.c
Log:
SVN rev 216111 on 2010-12-02 03:53:29Z by yongari
If RX lockup workaround is enabled, fxp(4) will periodically reset
the controller to workaround silicon bug of i82557. Each reset will
re-establish link which in turn triggers MII status change
callback. The callback will try to reconfigure controller if the
controller is not i82557 to enable flow-control. This caused
endless link UP/DOWN when the workaround was enabled on non-i82557
controller.
To fix the issue, apply RX lockup workaround only for i82557.
Previously it blindly checked undocumented EEPROM location such
that it sometimes enabled the workaround for other controllers. At
this time, only i82557 is known to have the silicon bug.
This fixes a regression introduced in r215906 which enabled flow
control support for all controllers except i82557.
Reported by: Karl Denninger (karl <> denninger dot net)
Tested by: Karl Denninger (karl <> denninger dot net)
MFC after: 3 days
Revision Changes Path
1.311 +6 -4 src/sys/dev/fxp/if_fxp.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201012020353.oB23rjuk034404>