Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 5 Jul 2016 15:53:44 -0700
From:      "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com>
To:        Bryan Drewery <bdrewery@FreeBSD.org>
Cc:        Peter Grehan <grehan@FreeBSD.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r302332 - head/usr.sbin/bhyve
Message-ID:  <2E25807A-B622-467B-B842-F40192273597@gmail.com>
In-Reply-To: <f7f697ad-a01b-e03e-b1a2-39ef1735cf24@FreeBSD.org>
References:  <201607040319.u643J6a2078082@repo.freebsd.org> <f7f697ad-a01b-e03e-b1a2-39ef1735cf24@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

[-- Attachment #1 --]

> On Jul 5, 2016, at 15:52, Bryan Drewery <bdrewery@FreeBSD.org> wrote:
> 
> On 7/3/2016 8:19 PM, Peter Grehan wrote:
>> Author: grehan
>> Date: Mon Jul  4 03:19:06 2016
>> New Revision: 302332
>> URL: https://svnweb.freebsd.org/changeset/base/302332
>> 
>> Log:
>>  Import bhyve_graphics into CURRENT. Thanks to all who tested
>>  this on the branch.
>> 
>>  Original commit message:
>>    Initial bhyve native graphics support.
>> 
>>    This adds emulations for a raw framebuffer device, PS2 keyboard/mouse,
>>    XHCI USB controller and a USB tablet.
>> 
>>    A simple VNC server is provided for keyboard/mouse input, and graphics
>>    output.
>> 
>>    A VGA emulation is included, but is currently disconnected until an
>>    additional bhyve change to block out VGA memory is committed.
>> 
>>    Credits:
>>     - raw framebuffer, VNC server, XHCI controller, USB bus/device emulation
>>        and UEFI f/w support by Leon Dang
>>     - VGA, console/g, initial VNC server  by tychon@
>>     - PS2 keyboard/mouse jointly done by tychon@ and Leon Dang
>>     - hypervisor framebuffer mem support by neel@
>> 
>>    Tested by: Michael Dexter, in a number of revisions of this code.
>> 
>>    With the appropriate UEFI image, FreeBSD, Windows and Linux guests can
>>    installed and run in graphics mode using the UEFI/GOP framebuffer.
> 
> This breaks the external GCC 5.2 build:
> 
> /builds/FreeBSD_HEAD_amd64_gcc/usr.sbin/bhyve/rfb.c: In function
> 'sse42_supported':
> /builds/FreeBSD_HEAD_amd64_gcc/usr.sbin/bhyve/rfb.c:885:17: error:
> 'bit_SSE42' undeclared (first use in this function)
>  return ((ecx & bit_SSE42) != 0);
>                 ^
> https://jenkins.freebsd.org/job/FreeBSD_HEAD_amd64_gcc/1334/console

It breaks gcc compilation in general. Here’s my proposed fix in progress: https://reviews.freebsd.org/D7119 .
Thanks,
-Ngie

[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org

iQIcBAEBCgAGBQJXfDp5AAoJEPWDqSZpMIYVFggP/j4CiPggv8oohMNdWdLT3O5L
DxNXi171YtvrpWNcLtw2mTivlquHL3YDEBMewfly+pk/pbuQLkoqjrXBzTvkiQWi
sPkte5D9zY7yzuCBqRbV5xY6v5QinhHlVstaA6dL2U37utBm+mgJASfiTunf6M8m
KkvmzIvjfkuGFFDuuUPUez7LceSUmQRL5AniUGjNoPKv1enbOaMojSWGglO7IOIK
YKcbeGaYRMM8ba5Ax7dGCliwyUVieChJEvThfGAleTFe9k8hhBF02of+wpPgT3na
JJUqvVDmRceDiLrTqs2DbRcbbBnZ1ySXCVYQLgEBir91O3jN760KngjCL6VXgS16
FQBkui6uV87dWy547H2GEdl0u89k0mamgmZURop/SGuMG5xQ8RKTa3cqW7TYuwCp
DeC8sJP1ZMbkTxNNrNUR7dT+nTZRCKxd3AHaVOtoBfrj0SGDA5LDIVJSOtmR/Hm2
0//IRpIS/a1KWCzTfA1X1bn44BXUwGxYY8c24xJrbHtcJ9xmtzt4zA5kXg9BeDqP
RvSefz4nzLZij4zEEKo07/4+b7bWKBBH5IoxxAKB207A49EXDPnrbjpAKNjEdLRA
xuddyU249cKhHbKQ9LgAOxjTOrJe0UZxEpeeksbNEvRHT0/juftz4ETa+FDfpl1F
NzkAg5gjB4zj2GJ4jN7V
=zs2b
-----END PGP SIGNATURE-----

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2E25807A-B622-467B-B842-F40192273597>