Date: Tue, 09 Jan 2001 14:37:57 -0800 From: Mike Smith <msmith@freebsd.org> To: Matt Jacob <mjacob@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/include bus.h Message-ID: <200101092237.f09MbvJ01112@mass.osd.bsdi.com> In-Reply-To: Your message of "Tue, 09 Jan 2001 10:17:49 PST." <200101091817.f09IHng10622@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> mjacob 2001/01/09 10:17:49 PST
>
> Modified files:
> sys/alpha/include bus.h
> Log:
> The alpha architecture is 64 bits, so bus_addr_t && bus_size_t should really
> be 64 bits wide. The largest known current actual physical implementation
> is 40 bits, so BUS_SPACE_MAXADDR should reflect this. It also seems to
> me that BUS_SPACE_UNRESTRICTED should b ~0UL, not ~0.
Where a constant is of a known type, one should avoid "UL" in favour of
the real type, eg. (~(bus_addr_t)0). There's too much "long" in the bus
code already. 8(
All IMO.
--
... every activity meets with opposition, everyone who acts has his
rivals and unfortunately opponents also. But not because people want
to be opponents, rather because the tasks and relationships force
people to take different points of view. [Dr. Fritz Todt]
V I C T O R Y N O T V E N G E A N C E
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200101092237.f09MbvJ01112>