Skip site navigation (1)Skip section navigation (2) 
Date:      Sun, 9 Aug 2015 19:12:43 +0000 (UTC)
From:      Alexander Motin <mav@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-vendor@freebsd.org
Subject:   svn commit: r286538 - vendor-sys/illumos/dist/uts/common/fs/zfs
Message-ID:  <201508091912.t79JCh5D085926@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: mav
Date: Sun Aug  9 19:12:43 2015
New Revision: 286538
URL: https://svnweb.freebsd.org/changeset/base/286538

Log:
  5562 ZFS sa_handle's violate kmem invariants, debug kernels panic on boot
  
  Reviewed by: Matthew Ahrens <mahrens@delphix.com>
  Reviewed by: Robert Mustacchi <rm@fingolfin.org>
  Reviewed by: George Wilson <george@delphix.com>
  Reviewed by: Rich Lowe <richlowe@richlowe.net>
  Approved by: Dan McDonald <danmcd@omniti.com>
  Author: Justin T. Gibbs <justing@spectralogic.com>
  
  illumos/illumos-gate@0fda3cc5c1c5a1d9bdea6d52637bef6e781549c9

Modified:
  vendor-sys/illumos/dist/uts/common/fs/zfs/sa.c

Modified: vendor-sys/illumos/dist/uts/common/fs/zfs/sa.c
==============================================================================
--- vendor-sys/illumos/dist/uts/common/fs/zfs/sa.c	Sun Aug  9 19:07:24 2015	(r286537)
+++ vendor-sys/illumos/dist/uts/common/fs/zfs/sa.c	Sun Aug  9 19:12:43 2015	(r286538)
@@ -211,13 +211,6 @@ sa_cache_constructor(void *buf, void *un
 {
 	sa_handle_t *hdl = buf;
 
-	hdl->sa_dbu.dbu_evict_func = NULL;
-	hdl->sa_bonus_tab = NULL;
-	hdl->sa_spill_tab = NULL;
-	hdl->sa_os = NULL;
-	hdl->sa_userp = NULL;
-	hdl->sa_bonus = NULL;
-	hdl->sa_spill = NULL;
 	mutex_init(&hdl->sa_lock, NULL, MUTEX_DEFAULT, NULL);
 	return (0);
 }
@@ -227,7 +220,6 @@ static void
 sa_cache_destructor(void *buf, void *unused)
 {
 	sa_handle_t *hdl = buf;
-	hdl->sa_dbu.dbu_evict_func = NULL;
 	mutex_destroy(&hdl->sa_lock);
 }
 
@@ -1351,14 +1343,11 @@ sa_handle_destroy(sa_handle_t *hdl)
 	mutex_enter(&hdl->sa_lock);
 	(void) dmu_buf_remove_user(db, &hdl->sa_dbu);
 
-	if (hdl->sa_bonus_tab) {
+	if (hdl->sa_bonus_tab)
 		sa_idx_tab_rele(hdl->sa_os, hdl->sa_bonus_tab);
-		hdl->sa_bonus_tab = NULL;
-	}
-	if (hdl->sa_spill_tab) {
+
+	if (hdl->sa_spill_tab)
 		sa_idx_tab_rele(hdl->sa_os, hdl->sa_spill_tab);
-		hdl->sa_spill_tab = NULL;
-	}
 
 	dmu_buf_rele(hdl->sa_bonus, NULL);
 
@@ -1392,10 +1381,13 @@ sa_handle_get_from_db(objset_t *os, dmu_
 		sa_handle_t *winner = NULL;
 
 		handle = kmem_cache_alloc(sa_cache, KM_SLEEP);
+		handle->sa_dbu.dbu_evict_func = NULL;
 		handle->sa_userp = userp;
 		handle->sa_bonus = db;
 		handle->sa_os = os;
 		handle->sa_spill = NULL;
+		handle->sa_bonus_tab = NULL;
+		handle->sa_spill_tab = NULL;
 
 		error = sa_build_index(handle, SA_BONUS);

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201508091912.t79JCh5D085926>