Date: Sat, 11 Oct 2014 04:57:17 +0000 (UTC) From: Neel Natu <neel@FreeBSD.org> To: src-committers@freebsd.org, svn-src-projects@freebsd.org Subject: svn commit: r272930 - projects/bhyve_svm/sys/amd64/vmm/amd Message-ID: <201410110457.s9B4vHnP027473@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: neel Date: Sat Oct 11 04:57:17 2014 New Revision: 272930 URL: https://svnweb.freebsd.org/changeset/base/272930 Log: Remove extraneous comments. Modified: projects/bhyve_svm/sys/amd64/vmm/amd/svm_softc.h Modified: projects/bhyve_svm/sys/amd64/vmm/amd/svm_softc.h ============================================================================== --- projects/bhyve_svm/sys/amd64/vmm/amd/svm_softc.h Sat Oct 11 04:41:21 2014 (r272929) +++ projects/bhyve_svm/sys/amd64/vmm/amd/svm_softc.h Sat Oct 11 04:57:17 2014 (r272930) @@ -38,7 +38,8 @@ struct asid { }; /* - * svm_vpcu contains SVM VMCB state and vcpu register state. + * XXX separate out 'struct vmcb' from 'svm_vcpu' to avoid wasting space + * due to VMCB alignment requirements. */ struct svm_vcpu { struct vmcb vmcb; /* hardware saved vcpu context */ @@ -54,29 +55,12 @@ struct svm_vcpu { * SVM softc, one per virtual machine. */ struct svm_softc { - /* - * IO permission map, VMCB.ctrl.iopm_base_pa should point to this. - * If a bit is set, access to I/O port is intercepted. - */ - uint8_t iopm_bitmap[SVM_IO_BITMAP_SIZE]; - - /* - * MSR permission bitmap, VMCB.ctrl.msrpm_base_pa should point to this. - * Two bits are used for each MSR with the LSB used for read access - * and the MSB used for write access. A value of '1' indicates that - * the operation is intercepted. - */ - uint8_t msr_bitmap[SVM_MSR_BITMAP_SIZE]; - + uint8_t iopm_bitmap[SVM_IO_BITMAP_SIZE]; /* shared by all vcpus */ + uint8_t msr_bitmap[SVM_MSR_BITMAP_SIZE]; /* shared by all vcpus */ uint8_t apic_page[VM_MAXCPU][PAGE_SIZE]; - /* Nested Paging */ - vm_offset_t nptp; - - /* Virtual machine pointer. */ - struct vm *vm; - - /* Guest VCPU h/w and s/w context. */ struct svm_vcpu vcpu[VM_MAXCPU]; + vm_offset_t nptp; /* nested page table */ + struct vm *vm; } __aligned(PAGE_SIZE); CTASSERT((offsetof(struct svm_softc, nptp) & PAGE_MASK) == 0);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201410110457.s9B4vHnP027473>