Date: Wed, 30 May 2018 13:51:48 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 228606] makeroot.sh w/ -f fails with duplicate definition errors Message-ID: <bug-228606-227-l4nbJFzJIV@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-228606-227@https.bugs.freebsd.org/bugzilla/> References: <bug-228606-227@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D228606 --- Comment #1 from commit-hook@freebsd.org --- A commit references this bug: Author: emaste Date: Wed May 30 13:51:00 UTC 2018 New revision: 334381 URL: https://svnweb.freebsd.org/changeset/base/334381 Log: makeroot.sh: allow duplicate entries even with -f <filelist> makefs disallows duplicate entries unless the -D option is specified. Previously makeroot.sh enabled -D unless a filelist was provided via the -f options. The filelist logic creates an mtree manifest from the METALOG and the provided filelist by passing them through `sort -u`, so duplicates were not expected. However, duplicates can still occur when a directory appears in multiple packages -- for example, ./etc/pam.d type=3Ddir uname=3Droot gname=3Dwheel mode=3D0755 ./etc/pam.d type=3Ddir mode=3D0755 tags=3Dpackage=3Druntime ./etc/pam.d type=3Ddir mode=3D0755 tags=3Dpackage=3Dat ./etc/pam.d type=3Ddir mode=3D0755 tags=3Dpackage=3Dftp ./etc/pam.d type=3Ddir mode=3D0755 tags=3Dpackage=3Dtelnet For the purposes of makefs these directory entries are identical, but are of course not identical for sort -u. For now just leave the allow duplicates -D flag enabled. PR: 228606 Sponsored by: The FreeBSD Foundation Changes: head/tools/tools/makeroot/makeroot.sh --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-228606-227-l4nbJFzJIV>