Date: Fri, 29 Jul 2011 20:30:28 +0000 (UTC) From: Alexander Motin <mav@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/sys/cam cam_periph.c Message-ID: <201107292030.p6TKUiE2090801@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
mav 2011-07-29 20:30:28 UTC
FreeBSD src repository
Modified files:
sys/cam cam_periph.c
Log:
SVN rev 224496 on 2011-07-29 20:30:28Z by mav
In some cases failed SATA disks may report their presence, but don't
respond to any commands. I've found that because of multiple command
retries, each of which cause 30s timeout, bus reset and another retry or
requeue for many commands, it may take ages to eventually drop the
failed device. The odd thing is that those retries continue even after
XPT considered device as dead and invalidated it.
This patch makes cam_periph_error() to block any command retries after
periph was marked as invalid. With that patch all activity completes in
1-2 minutes, just after several timeouts, required to consider device
death. This should make ZFS, gmirror, graid, etc. operation more robust.
Reviewed by: mjacob@ on scsi@
Approved by: re (kib)
Revision Changes Path
1.97 +19 -8 src/sys/cam/cam_periph.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201107292030.p6TKUiE2090801>