Date: Tue, 09 Jan 2018 09:05:56 -0800 From: John Baldwin <jhb@freebsd.org> To: Warner Losh <imp@bsdimp.com> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r327705 - head/stand/mips/beri/common Message-ID: <1620808.I0a57TDRna@ralph.baldwin.cx> In-Reply-To: <CANCZdfqzhB41_iizFhooqxU2-z3%2BaD%2BtL5hfDWgU-FRb_dV0Kw@mail.gmail.com> References: <201801081847.w08IlZ7F033684@repo.freebsd.org> <CANCZdfqzhB41_iizFhooqxU2-z3%2BaD%2BtL5hfDWgU-FRb_dV0Kw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday, January 08, 2018 12:02:09 PM Warner Losh wrote: > This should have been a nop... libsa specifically creates 'safe' headers > for all the standard ones. > > Ah, libsa creates a perfectly fine stdint.h, but not a inttypes.h... Would you prefer it to use stdint.h and stdio.h rather than stand.h? > Warner > > On Mon, Jan 8, 2018 at 11:47 AM, John Baldwin <jhb@freebsd.org> wrote: > > > Author: jhb > > Date: Mon Jan 8 18:47:35 2018 > > New Revision: 327705 > > URL: https://svnweb.freebsd.org/changeset/base/327705 > > > > Log: > > Use <stand.h> instead of <inttypes.h> and <stdio.h> in boot code. > > > > In the freestanding boot compile environment, standard headers are not > > available. Curiously, only building with clang exposed this as compiles > > with external GCC still succeeded. > > > > Sponsored by: DARPA / AFRL > > > > Modified: > > head/stand/mips/beri/common/sdcard.c > > > > Modified: head/stand/mips/beri/common/sdcard.c > > ============================================================ > > ================== > > --- head/stand/mips/beri/common/sdcard.c Mon Jan 8 18:46:10 2018 > > (r327704) > > +++ head/stand/mips/beri/common/sdcard.c Mon Jan 8 18:47:35 2018 > > (r327705) > > @@ -33,8 +33,7 @@ > > #include <sys/types.h> > > #include <sys/endian.h> > > > > -#include <inttypes.h> > > -#include <stdio.h> > > +#include <stand.h> > > > > > > /* > > > > -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1620808.I0a57TDRna>