Date: Thu, 10 Jul 2014 01:25:36 +0200 From: Baptiste Daroussin <bapt@freebsd.org> To: Adrian Chadd <adrian@freebsd.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, Pedro Giffuni <pfg@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r268461 - in head: . gnu/lib/libreadline gnu/lib/libreadline/history gnu/lib/libreadline/readline gnu/lib/libreadline/readline/doc gnu/usr.bin/gdb gnu/usr.bin/gdb/gdb gnu/usr.bin/gdb/gd... Message-ID: <20140709232536.GF56040@ivaldir.etoilebsd.net> In-Reply-To: <CAJ-Vmo=kLQ27km1hRcwFsinmBMA=UVWcZyw5gBLJ-V1UvQPuOw@mail.gmail.com> References: <201407091552.s69FqUon070685@svn.freebsd.org> <53BD68E4.1070706@freebsd.org> <CAJ-VmonsZzATyWC9g-pxaQ_qDSvOh-jbiWhY=92vgmovqvn-BQ@mail.gmail.com> <20140709172305.GD56040@ivaldir.etoilebsd.net> <CAJ-Vmo=kLQ27km1hRcwFsinmBMA=UVWcZyw5gBLJ-V1UvQPuOw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Wed, Jul 09, 2014 at 11:05:29AM -0700, Adrian Chadd wrote: > On 9 July 2014 10:23, Baptiste Daroussin <bapt@freebsd.org> wrote: > > On Wed, Jul 09, 2014 at 10:12:27AM -0700, Adrian Chadd wrote: > >> Hi, > >> > >> By doing this you're actually making more work for the really embedded > >> people who have size constraints on things. > >> > >> I dislike privatelib but it at least allows for code sharing where > >> before people would just statically link things into binaries. > > > > do you install gdb on your embedded environnement? because that is the only > > user of libreadline. > > See below. > > >> > >> I've had to actively undo this kind of dumb before in order to get > >> things to fit on very small flash root filesystems. > >> > >> Shared libraries are good. Please stop assuming we have lots of disk > >> space and RAM to have duplicates of things floating around. > > > > Facts: > > Before > > gdb + kgdb + gdbtui + libreadline.so.8 + libhistory.so.8 = 8976 k > > After > > gdb + kgdb + gdbtui = 8973 k > > > > I don't think I have damaged too much your embedded system am I wrong? > > > > Do I miss something? > > > > (Yes I have checked that before turning into an internallib given my first > > approach was to turn into a privatelib. > > Sure, except for the people who have done things like rolled local > configuration/management telnet interfaces for these things. They're > also using libreadline (and things like the cisco UI library.) > > And yeah, I do install gdb in there from time to time. Code sometimes > needs debugging. :-) > They can in that case use libedit which exports a libreadline compatibility interface in the base system (it is working well with the known cisco-like UI things ;) so even in that case I save them space given libedit is required for /bin/sh (the only known problem can happen if the are using unicode and from my last test the cisco UI thing is not unicode friendly either so that should make no difference here for them). The other thing is there are a couple of ABI incompatibilities between the libreadline version we have in base and newer libreadline which is getting more and more use making it more complicated to manage ports that requires newer readline. regards, Bapt [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlO9z3AACgkQ8kTtMUmk6Ew4IACfQ6mRfHJ9enFb436Hq/XGZoEZ Vv0AnAwwmjkVFLYCzyhPSZOI4Nq9k1+k =8NkS -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140709232536.GF56040>