Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 01 Dec 2014 10:34:37 -0500
From:      John Baldwin <jhb@freebsd.org>
To:        Hans Petter Selasky <hps@selasky.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r275358 - in head/sys: dev/bxe dev/cxgb dev/cxgbe dev/e1000 dev/ixgbe dev/ixl dev/mxge dev/netmap dev/oce dev/qlxgbe dev/qlxge dev/sfxge dev/virtio/network dev/vmware/vmxnet3 dev/vxge n...
Message-ID:  <2020433.4XkkFeczi5@ralph.baldwin.cx>
In-Reply-To: <547C8625.3030000@selasky.org>
References:  <201412011145.sB1BjPEI092904@svn.freebsd.org> <2301463.0AvfjFzmc1@ralph.baldwin.cx> <547C8625.3030000@selasky.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Monday, December 01, 2014 04:15:49 PM Hans Petter Selasky wrote:
> Hi John,
> 
> These patches were sent to the -current mailing list for review for 12
> days. No big issues were mentioned.
> 
> Also a review has been made at "reviews.freebsd.org":
> https://reviews.freebsd.org/D1243
> 
> No response yet.
> 
> If I missed someone for the review process please let me know.

Even if no one comments, please include the review URL in the "Differential 
Review" field.  Also, I think you could probably have put 'Discussed with:  
adrian, kmacy' in the commit.  Arguably from the followups in that thread you 
might have been able to put "Reviewed by: adrian" as well if this is just the 
cleanup patches that he said were ok.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2020433.4XkkFeczi5>