Date: Wed, 27 Oct 2010 09:12:47 -0400 From: John Baldwin <jhb@freebsd.org> To: freebsd-hackers@freebsd.org Cc: Lars Hartmann <lars@chaotika.org>, Sergey Kandaurov <pluknet@gmail.com> Subject: Re: [PATCH] Fix 'implicit declaration' warning and update vgone(9) Message-ID: <201010270912.47076.jhb@freebsd.org> In-Reply-To: <AANLkTimCN%2BY4OsJRNvdmXidLu8XPHz5RydAhe0phvgnH@mail.gmail.com> References: <1288160610.4280.18.camel@apollon> <AANLkTimCN%2BY4OsJRNvdmXidLu8XPHz5RydAhe0phvgnH@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday, October 27, 2010 7:33:13 am Sergey Kandaurov wrote: > On 27 October 2010 10:23, Lars Hartmann <lars@chaotika.org> wrote: > > The vgonel function isnt declarated in any header, the vgonel prototype > > in vgone(9) isnt correct - found by Ben Kaduk <kaduk@mit.edu> > > Hi. > > I'm afraid it's just an overlooked man page after many VFS changes in 5.x. > As vgonel() is a static (i.e. private and not visible from outside) function > IMO it should be removed from vgone(9) man page. Agreed. It certainly should not be added to vnode.h. I'm curious how the reporter is getting a warning since there is a static prototype for vgonel() in vfs_subr.c. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201010270912.47076.jhb>