Date: Wed, 23 Oct 2024 09:51:27 -0400 From: John Baldwin <jhb@FreeBSD.org> To: Baptiste Daroussin <bapt@freebsd.org>, Li-Wen Hsu <lwhsu@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 419249c1cacc - main - Revert "LINT: Add mac_do" Message-ID: <1b16aaec-e586-4e5c-a764-0e1eed7c9611@FreeBSD.org> In-Reply-To: <aim256gaqcl32xkyjm4c4tce4ynnlfyswnro5ojmscv6jtz3xh@2v5fxpksff27> References: <202410230740.49N7efYQ065894@gitrepo.freebsd.org> <aim256gaqcl32xkyjm4c4tce4ynnlfyswnro5ojmscv6jtz3xh@2v5fxpksff27>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10/23/24 03:47, Baptiste Daroussin wrote: > On Wed 23 Oct 07:40, Li-Wen Hsu wrote: >> The branch main has been updated by lwhsu: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=419249c1cacca2cfdf5128ead2873a9fd57f112e >> >> commit 419249c1cacca2cfdf5128ead2873a9fd57f112e >> Author: Li-Wen Hsu <lwhsu@FreeBSD.org> >> AuthorDate: 2024-10-23 07:40:14 +0000 >> Commit: Li-Wen Hsu <lwhsu@FreeBSD.org> >> CommitDate: 2024-10-23 07:40:14 +0000 >> >> Revert "LINT: Add mac_do" >> >> This reverts commit 91b7b225b2ce577381aae989c361b9b5b6dd1500. > > It would be interesting to get the why in the commit log here, to understand > what needs to be fixed. I was about to reply with the same thought, that in general we should try to add the "why" when reverting a change and not just use the raw generated log from git revert. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1b16aaec-e586-4e5c-a764-0e1eed7c9611>