Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 6 Jan 2009 00:07:57 +0300
From:      Stanislav Sedov <stas@FreeBSD.org>
To:        Alfred Perlstein <alfred@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Hans Petter Selasky <hselasky@c2i.net>
Subject:   Re: svn commit: r186730 - in head: lib/libusb20 sys/dev/usb2/controller sys/dev/usb2/core sys/dev/usb2/ethernet sys/dev/usb2/image sys/dev/usb2/include sys/dev/usb2/serial sys/dev/usb2/sound sys/dev/us...
Message-ID:  <20090106000757.9c92d93d.stas@FreeBSD.org>
In-Reply-To: <200901040012.n040C2gH040928@svn.freebsd.org>
References:  <200901040012.n040C2gH040928@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 4 Jan 2009 00:12:02 +0000 (UTC)
Alfred Perlstein <alfred@FreeBSD.org> mentioned:

> Author: alfred
> Date: Sun Jan  4 00:12:01 2009
> New Revision: 186730
> URL: http://svn.freebsd.org/changeset/base/186730
> 
> Log:
>   Sync with usb4bsd:
>   
>   src/lib/libusb20/libusb20_desc.c
>   
>   Make "libusb20_desc_foreach()" more readable.
>   
>   src/sys/dev/usb2/controller/*.[ch]
>   src/sys/dev/usb2/core/*.[ch]
>   
>   Implement support for USB power save for all HC's.
>   
>   Implement support for Big-endian EHCI.
>   
>   Move Huawei quirks back into "u3g" driver.
>   
>   Improve device enumeration.
>   
>   src/sys/dev/usb2/ethernet/*[ch]
>   
>   Patches for supporting new AXE Gigabit chipset.
>   
>   src/sys/dev/usb2/serial/*[ch]
>   
>   Fix IOCTL return code.
>   
>   src/sys/dev/usb2/wlan/*[ch]
>   
>   Sync with old USB stack.
>   
>   Submitted by: hps

...

> +#if (USB_DEBUG != 0)
> +	if (rem != (USB_P2U(pc->buffer) & (USB_PAGE_SIZE - 1))) {
> +		/*
> +		 * This check verifies that the physical address is correct:
> +		 */
> +		DPRINTFN(0, "Page offset was not preserved!\n");
> +		error = 1;
> +		goto done;
> +	}
> +#endif
>  	while (nseg > 0) {
>  		nseg--;
>  		segs++;
> @@ -788,7 +800,16 @@
>  		ext_seg = 0;
>  	}
>  	nseg--;
> -
> +#if (USB_DEBUG != 0)
> +	if (rem != (USB_P2U(pc->buffer) & (USB_PAGE_SIZE - 1))) {
> +		/*
> +		 * This check verifies that the physical address is correct:
> +		 */
> +		DPRINTFN(0, "Page offset was not preserved!\n");
> +		error = 1;
> +		goto done;
> +	}
> +#endif

This bits prevent usb2 from working on my desktop with the following messages:
usb2_pc_common_mem_cb:429: Page offset was not preserved!
usb2_alloc_device:1423: set address 2 failed (ignored)
usb2_pc_common_mem_cb:429: Page offset was not preserved!
usb2_alloc_device:1458: getting device descriptor at addr 2 failed!
usb2_pc_common_mem_cb:429: Page offset was not preserved!
usb2_alloc_device:1423: set address 2 failed (ignored)
usb2_pc_common_mem_cb:429: Page offset was not preserved!
usb2_alloc_device:1458: getting device descriptor at addr 2 failed!
usb2_pc_common_mem_cb:429: Page offset was not preserved!
usb2_req_re_enumerate:1362: addr=2, set address failed! (ignored)
usb2_pc_common_mem_cb:429: Page offset was not preserved!
usb2_req_re_enumerate:1375: getting device descriptor at addr 2 failed!
usb2_pc_common_mem_cb:429: Page offset was not preserved!
usb2_req_re_enumerate:1362: addr=2, set address failed! (ignored)
usb2_pc_common_mem_cb:429: Page offset was not preserved!
usb2_req_re_enumerate:1375: getting device descriptor at addr 2 failed!
Starting Network: lo0 em0.
Waiting 30s for an interface to come up: 
usb2_pc_common_mem_cb:429: Page offset was not preserved!
usb2_req_re_enumerate:1362: addr=2, set address failed! (ignored)
usb2_pc_common_mem_cb:429: Page offset was not preserved!
usb2_req_re_enumerate:1375: getting device descriptor at addr 2 failed!
ugen3.2: <> at usbus3 (disconnected)
uhub_reattach_port:417: could not allocate new device!
usb2_pc_common_mem_cb:429: Page offset was not preserved!
usb2_req_re_enumerate:1362: addr=2, set address failed! (ignored)
usb2_pc_common_mem_cb:429: Page offset was not preserved!
usb2_req_re_enumerate:1375: getting device descriptor at addr 2 failed!
ugen1.2: <> at usbus1 (disconnected)
uhub_reattach_port:417: could not allocate new device!

Can you take a look at this?

Thanks!

-- 
Stanislav Sedov
ST4096-RIPE

!DSPAM:4962761d967001591710962!





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090106000757.9c92d93d.stas>