Date: Mon, 1 Apr 2024 10:12:11 +0000 From: eweweew rob <der_marner15@hotmail.de> To: Andriy Gapon <avg@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org> Subject: Re: git: 4d1161f094dd - main - subr_bus: report DEVICE_SUSPEND failures Message-ID: <GV1PR08MB790079E9050227030C97769D803F2@GV1PR08MB7900.eurprd08.prod.outlook.com> In-Reply-To: <AB8F544B-D69E-4D9F-861D-B8B59FA7C7ED@yahoo.com> References: <202401281321.40SDLneL052092@gitrepo.freebsd.org> <AB8F544B-D69E-4D9F-861D-B8B59FA7C7ED@yahoo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] Good afternoon, Could you please unsubscribe me from the group? Greets André ________________________________ From: owner-dev-commits-src-all@freebsd.org <owner-dev-commits-src-all@freebsd.org> on behalf of Quincy Mcrae <qgmcrae@yahoo.com> Sent: Sunday, January 28, 2024 5:28:23 PM To: Andriy Gapon <avg@freebsd.org> Cc: src-committers@freebsd.org <src-committers@freebsd.org>; dev-commits-src-all@freebsd.org <dev-commits-src-all@freebsd.org>; dev-commits-src-main@freebsd.org <dev-commits-src-main@freebsd.org> Subject: Re: git: 4d1161f094dd - main - subr_bus: report DEVICE_SUSPEND failures Good afternoon, Could you please unsubscribe me from the group? Quincy Sent from my iPhone > On Jan 28, 2024, at 9:21 AM, Andriy Gapon <avg@freebsd.org> wrote: > > The branch main has been updated by avg: > > URL: https://cgit.FreeBSD.org/src/commit/?id=4d1161f094dd90428847f7e5989767e9957055f4 > > commit 4d1161f094dd90428847f7e5989767e9957055f4 > Author: Andriy Gapon <avg@FreeBSD.org> > AuthorDate: 2023-01-03 08:39:32 +0000 > Commit: Andriy Gapon <avg@FreeBSD.org> > CommitDate: 2024-01-28 13:21:09 +0000 > > subr_bus: report DEVICE_SUSPEND failures > > This greatly aids with diagnosing system suspend failures when > they are due to a device driver or hardware. > --- > sys/kern/subr_bus.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/sys/kern/subr_bus.c b/sys/kern/subr_bus.c > index 21c2835f2ae6..c06f3df0c9c9 100644 > --- a/sys/kern/subr_bus.c > +++ b/sys/kern/subr_bus.c > @@ -3463,8 +3463,12 @@ bus_generic_suspend_child(device_t dev, device_t child) > > error = DEVICE_SUSPEND(child); > > - if (error == 0) > + if (error == 0) { > child->flags |= DF_SUSPENDED; > + } else { > + printf("DEVICE_SUSPEND(%s) failed: %d\n", > + device_get_nameunit(child), error); > + } > > return (error); > } > [-- Attachment #2 --] <html> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> </head> <body> <div dir="auto">Good afternoon,</div> <div dir="auto"><br> </div> <div dir="auto">Could you please unsubscribe me from the group?</div> <div dir="auto"><br> </div> <div dir="auto">Greets</div> <div dir="auto"><br> </div> <div dir="auto">André </div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> owner-dev-commits-src-all@freebsd.org <owner-dev-commits-src-all@freebsd.org> on behalf of Quincy Mcrae <qgmcrae@yahoo.com><br> <b>Sent:</b> Sunday, January 28, 2024 5:28:23 PM<br> <b>To:</b> Andriy Gapon <avg@freebsd.org><br> <b>Cc:</b> src-committers@freebsd.org <src-committers@freebsd.org>; dev-commits-src-all@freebsd.org <dev-commits-src-all@freebsd.org>; dev-commits-src-main@freebsd.org <dev-commits-src-main@freebsd.org><br> <b>Subject:</b> Re: git: 4d1161f094dd - main - subr_bus: report DEVICE_SUSPEND failures</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt;"> <div class="PlainText">Good afternoon,<br> <br> Could you please unsubscribe me from the group?<br> <br> Quincy<br> Sent from my iPhone<br> <br> > On Jan 28, 2024, at 9:21 AM, Andriy Gapon <avg@freebsd.org> wrote:<br> > <br> > The branch main has been updated by avg:<br> > <br> > URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=4d1161f094dd90428847f7e5989767e9957055f4">; https://cgit.FreeBSD.org/src/commit/?id=4d1161f094dd90428847f7e5989767e9957055f4</a><br>; > <br> > commit 4d1161f094dd90428847f7e5989767e9957055f4<br> > Author: Andriy Gapon <avg@FreeBSD.org><br> > AuthorDate: 2023-01-03 08:39:32 +0000<br> > Commit: Andriy Gapon <avg@FreeBSD.org><br> > CommitDate: 2024-01-28 13:21:09 +0000<br> > <br> > subr_bus: report DEVICE_SUSPEND failures<br> > <br> > This greatly aids with diagnosing system suspend failures when<br> > they are due to a device driver or hardware.<br> > ---<br> > sys/kern/subr_bus.c | 6 +++++-<br> > 1 file changed, 5 insertions(+), 1 deletion(-)<br> > <br> > diff --git a/sys/kern/subr_bus.c b/sys/kern/subr_bus.c<br> > index 21c2835f2ae6..c06f3df0c9c9 100644<br> > --- a/sys/kern/subr_bus.c<br> > +++ b/sys/kern/subr_bus.c<br> > @@ -3463,8 +3463,12 @@ bus_generic_suspend_child(device_t dev, device_t child)<br> > <br> > error = DEVICE_SUSPEND(child);<br> > <br> > - if (error == 0)<br> > + if (error == 0) {<br> > child->flags |= DF_SUSPENDED;<br> > + } else {<br> > + printf("DEVICE_SUSPEND(%s) failed: %d\n",<br> > + device_get_nameunit(child), error);<br> > + }<br> > <br> > return (error);<br> > }<br> > <br> <br> <br> </div> </span></font></div> </body> </html>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?GV1PR08MB790079E9050227030C97769D803F2>