Date: Sat, 25 Oct 2025 21:40:31 +0200 From: Michael Gmelin <grembo@freebsd.org> To: Daniel Engberg <diizzy@freebsd.org> Cc: Po-Chuan Hsieh <sunpoet@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: f0382e54e643 - main - graphics/proj: Add LICENSE_FILE Message-ID: <D557F4F9-A66C-41D2-AC58-D7311B685C02@freebsd.org> In-Reply-To: <9f593091-52a7-4c03-a70c-99c25fe98aaa@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
> On 25. Oct 2025, at 15:48, Daniel Engberg <diizzy@freebsd.org> wrote: > > On 2025-10-25 15:24, Michael Gmelin wrote: >>>> On 25. Oct 2025, at 15:18, Daniel Engberg <diizzy@freebsd.org> wrote: >>> >>> On 2025-10-25 15:09, Michael Gmelin wrote: >>>>>> On 25. Oct 2025, at 14:53, Daniel Engberg <diizzy@freebsd.org> wrote: >>>>> >>>>> On 2025-10-25 14:49, Michael Gmelin wrote: >>>>>>>> On 25. Oct 2025, at 14:43, Daniel Engberg <diizzy@freebsd.org> wrote: >>>>>>> >>>>>>> On 2025-10-25 14:22, Po-Chuan Hsieh wrote: >>>>>>>> The branch main has been updated by sunpoet: >>>>>>>> >>>>>>>> URL: https://cgit.FreeBSD.org/ports/commit/? id=f0382e54e643633e01daabd63eae23851f0c7764 >>>>>>>> >>>>>>>> commit f0382e54e643633e01daabd63eae23851f0c7764 >>>>>>>> Author: Po-Chuan Hsieh <sunpoet@FreeBSD.org> >>>>>>>> AuthorDate: 2025-10-25 12:21:16 +0000 >>>>>>>> Commit: Po-Chuan Hsieh <sunpoet@FreeBSD.org> >>>>>>>> CommitDate: 2025-10-25 12:21:16 +0000 >>>>>>>> >>>>>>>> graphics/proj: Add LICENSE_FILE >>>>>>>> Approved by: portmgr (blanket) >>>>>>>> --- >>>>>>>> graphics/proj/Makefile | 2 +- >>>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>>>>> >>>>>>>> diff --git a/graphics/proj/Makefile b/graphics/proj/Makefile >>>>>>>> index 9909e35de29f..0d3a2e1c4064 100644 >>>>>>>> --- a/graphics/proj/Makefile >>>>>>>> +++ b/graphics/proj/Makefile >>>>>>>> @@ -10,7 +10,7 @@ COMMENT= Cartographic Projections library >>>>>>>> WWW= https://github.com/OSGeo/PROJ >>>>>>>> LICENSE= MIT >>>>>>>> -#LICENSE_FILE= ${WRKSRC}/COPYING >>>>>>>> +LICENSE_FILE= ${WRKSRC}/COPYING >>>>>>>> BUILD_DEPENDS= nlohmann-json>=3:devel/nlohmann-json >>>>>>>> LIB_DEPENDS= libcurl.so:ftp/curl \ >>>>>>> >>>>>>> This is clearly incorrect if you actually read COPYING, back this out. >>>>>>> >>>>>> See https://proj.org/en/stable/about.html#license <https://proj.org/en/ stable/about.html#license> >>>>> >>>>> Not sure what you're replying to? >>>>> https://github.com/OSGeo/PROJ/blob/9.7.0/COPYING >>>>> >>>>> https://docs.freebsd.org/en/books/porters-handbook/book/#licenses-license_file >>>> Did you follow the link I shared? >>>> "PROJ uses the MIT license. The software was initially released by the USGS in the public domain. When Frank Warmerdam took over the development of PROJ it was moved under the MIT license. The full text of the license follows, and can also be found in the file COPYING, at the top level of the source distribution package." >>>> If you read COPYING, the first part explains what the license was in previous versions and then is followed by the license text of the current version (which is MIT, as far as I can tell). >>>> At least that’s my understanding. >>>> Best >>> ...and if you read Porters Handbook, "Full path to the file containing the license text". It's not complete which likely is the reason why its not added in the first place and additionally also refers to other files. >> I don’t really follow tbh. >> -m > > The defined file in LICENSE_FILE should be complete otherwise the whole point in referring to it would be meaningless and potentially harmful. In this case it's missing copyright holders which is a requirement unless multiple sources are incorrect. > > The license itself also refers to this, > "The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software." > > https://opensource.org/license/mit > https://spdx.org/licenses/MIT.html > https://en.wikipedia.org/wiki/MIT_License Well, technically the porter’s handbook says "Full path to the file containing the license text," and not "path to the file containing the full license text". Also, the upstream project clearly states that this is their license text. So IMHO the port is correct, but the upstream project might have issues. No matter what, I don’t think that it’s "clearly incorrect". Best Michaelhelp
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D557F4F9-A66C-41D2-AC58-D7311B685C02>